[Request-For-Global] Page 40 "Item Journal" - Procedure from local to global

[AurimasPileckis]

Why do you need this change?

In our extension we are using customized local procedure OpenJournal() and we can't handle our solution with existing handlers. That's why we need SetControlAppearanceFromBatch() procedure to be reachable in our extension.

Describe the request

Dear ALAppExtensions team,

On behalf of 4PS, I would like to request an update to the local procedure SetControlAppearanceFromBatch()

We need to access this procedure from our custom codeunit, so we kindly request that its scope be changed to global.
Internal work item: AB#617042

[AleksandricMarko]

✅ Analysis complete - approved for implementation

---

Implementation:

Change the SetControlAppearanceFromBatch() procedure from local to public scope.

Current code:

local procedure SetControlAppearanceFromBatch()
var
    ItemJournalBatch: Record "Item Journal Batch";
    ItemTrackingCode: Record "Item Tracking Code";
    BackgroundErrorHandlingMgt: Codeunit "Background Error Handling Mgt.";
begin
    if not ItemJournalBatch.Get(Rec.GetRangeMax("Journal Template Name"), CurrentJnlBatchName) then
        exit;

    BackgroundErrorCheck := BackgroundErrorHandlingMgt.BackgroundValidationFeatureEnabled();
    ShowAllLinesEnabled := true;

    CanSelectItemTrackingOnLines := ItemJournalBatch."Item Tracking on Lines";
    ItemTrackingCode.SetRange("Package Specific Tracking", true);
    PackageNoVisible := CanSelectItemTrackingOnLines and not ItemTrackingCode.IsEmpty();

    Rec.SwitchLinesWithErrorsFilter(ShowAllLinesEnabled);
    ItemJournalErrorsMgt.SetFullBatchCheck(true);
end;

Proposed change:

procedure SetControlAppearanceFromBatch()
var
    ItemJournalBatch: Record "Item Journal Batch";
    ItemTrackingCode: Record "Item Tracking Code";
    BackgroundErrorHandlingMgt: Codeunit "Background Error Handling Mgt.";
begin
    if not ItemJournalBatch.Get(Rec.GetRangeMax("Journal Template Name"), CurrentJnlBatchName) then
        exit;

    BackgroundErrorCheck := BackgroundErrorHandlingMgt.BackgroundValidationFeatureEnabled();
    ShowAllLinesEnabled := true;

    CanSelectItemTrackingOnLines := ItemJournalBatch."Item Tracking on Lines";
    ItemTrackingCode.SetRange("Package Specific Tracking", true);
    PackageNoVisible := CanSelectItemTrackingOnLines and not ItemTrackingCode.IsEmpty();

    Rec.SwitchLinesWithErrorsFilter(ShowAllLinesEnabled);
    ItemJournalErrorsMgt.SetFullBatchCheck(true);
end;

---

File: ItemJournal.Page.al