Skip to content

Unable to edit from the query builder with multiple-cursors #138

@troyfigiel

Description

@troyfigiel

With combobulate-cursor-tool set to 'multiple-cursors, I am unable to edit nodes from the query builder. I assume what was meant was "either combobulate-cursor-tool is not set to 'multiple-cursors, or the query contains one of the three before, after or mark names" instead of the "and" that is currently used:

diff --git a/combobulate-query.el b/combobulate-query.el
index f114f8b..1a88939 100644
--- a/combobulate-query.el
+++ b/combobulate-query.el
@@ -771,10 +771,10 @@ buffer."
                  query nil nil nil)))
     ;; Search the query string for `@before', `@after', and `@mark' capture
     ;; groups. Raise an error if neither are present.
-    (unless (and (not (eq combobulate-cursor-tool 'multiple-cursors))
-                 (or (string-match-p "@before" query)
-                     (string-match-p "@after" query)
-                     (string-match-p "@mark" query)))
+    (unless (or (not (eq combobulate-cursor-tool 'multiple-cursors))
+                (string-match-p "@before" query)
+                (string-match-p "@after" query)
+                (string-match-p "@mark" query))
       (error "You are editing with multiple cursors. Please mark nodes with `@before', `@after', and/or `@mark' to determine cursor placement"))
     (if (>= (length nodes) combobulate-query-builder-edit-max-nodes)
         (error "Too many nodes to edit (%d)" (length nodes))

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions