Skip to content

PERFORMANCE: JSON vs Oj  #14

@lgs

Description

@lgs

I notice that BB make extensive use of JSON standard lib. Shouldn't be better to wire in Oj instead ?

./lib/google_bigquery/jobs.rb

      job_id = JSON.parse(res.body)["jobReference"]["jobId"]
        status = JSON.parse(self.get(project_id, job_id).body)
      job_id = JSON.parse(res.body)["jobReference"]["jobId"]
        status = JSON.parse(self.get(project_id, job_id).body)

./lib/google_bigquery/client.rb

      JSON.parse(res.body)
      JSON.parse(res.body)
      body = JSON.parse(@results.body)
      body = JSON.parse(res.body)

./lib/active_record/connection_adapters/bigquery_adapter.rb

          json = JSON.parse(file.read)

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions