Rug API compatibility?

[ThomasCartier]

Hi!

Quick question.

Would a very close API compatibility with rug be an option?
Currently have to deal with both for server vs wasm contexts and it is more complex than necessary.
Maybe a common trait (certainly quite big and impractical) or new methods to replicate it could do it?

for example: new(), from(..) and co

Thanks

[ThomasCartier]

I will create that compat trait (not now but in a week or so).
I don't think you want to embed that compatibility layer into your project (and that is fine), but if it's something you could be interested into, just ping me.

I will close this issue for now.

[mhogrefe]

Hi Thomas!

This is a good idea, just not one that I have time to implement myself. Steve Shi did this for num.

[ThomasCartier]

Ok I will work on it. I will make a PR here then. The APIs are stable enough so that it shouldn't change that much/often

[ThomasCartier]

Just a quick update, I had a look at both rug and malachite sources. Both implement the num trait at least partially, impl many required ops, so maybe a different way to approach it is using a supertrait. We would still be able to use impl X or T in generic contexts. No need to duplicate any impl. That is easier to maintain (a single -long- line in the project) and deliver the same unified experience. I will work on it pretty soon now and adapt this strategy accordingly.

[ThomasCartier]

Finally, I had some time to work on it and test it on the battlefield. I need to rework the dev experience by rewriting a very large part of the surface API to make it pleasant to use.

The trait only approach lead to an abysmal verbosity. I dislike it. So I will release it in my repo once done and make an update here.
I will need a few days more to cover the Integer part. If I find enough time, I will also do the Float.

Not sure about Rationals yet.

[ThomasCartier]

@mhogrefe : Do you plan to implement a true euclidean division or should I arrange the remainder myself from the floor variant?

let (q, r) = a.div_rem_floor(b);

if r < 0 {
    if b > 0 {
        (q - 1, r + b)
    } else {
        (q + 1, r - b)
    }
} else {
    (q, r)
}

or similar depending on the API.

[ThomasCartier]

@mhogrefe : another quick question: for the limbs, do you plan to propose a slice version that avoids copies using .to_twos_complement_limbs_asc() I could make it work with a Cow right now, but for efficiency, it would be very nice to have it!

[ThomasCartier]

@mhogrefe last question for today: do you plan to have some optimized assign methods that would reuse the already allocated memory, like rug does with it's assign methods (that would be awesome)?