Skip to content

Vt 28545 #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
velichkin wants to merge 30 commits into
base: master
Choose a base branch
from
Open

Vt 28545 #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
22cd874
VT-28545 Implement MGID Widget inside AMP Stories
velichkin Dec 12, 2022
17e4c71
VT-28545 Implement MGID Widget inside AMP Stories
velichkin Dec 12, 2022
6062361
VT-28545 Implement MGID Widget inside AMP Stories. Static screen size
velichkin Dec 12, 2022
d783699
VT-28545 Implement MGID Widget inside AMP Stories. Fix 3p iframe impl…
velichkin Dec 14, 2022
8866b63
VT-28545 Implement MGID Widget inside AMP Stories. Fix consents
velichkin Dec 15, 2022
39bd971
VT-28545 Implement MGID Widget inside AMP Stories. Tests
velichkin Dec 15, 2022
35de853
VT-28545 Implement MGID Widget inside AMP Stories. Readme
velichkin Dec 15, 2022
eb668ba
Merge branch 'master' into VT-28545
velichkin Dec 16, 2022
8ef57c2
VT-28545 Implement MGID Widget inside AMP Stories. Fix eslint
velichkin Dec 16, 2022
4945022
VT-28545 Implement MGID Widget inside AMP Stories. Fix eslint
velichkin Dec 16, 2022
535c8e4
VT-28545 Implement MGID Widget inside AMP Stories. Add tests
velichkin Dec 16, 2022
db0e938
VT-28545 Implement MGID Widget inside AMP Stories. linter fixes
velichkin Dec 16, 2022
8cad691
VT-28545 Implement MGID Widget inside AMP Stories. Fix deps
velichkin Dec 16, 2022
2973d40
VT-28545 Implement MGID Widget inside AMP Stories. VT-28613 - remove …
velichkin Dec 27, 2022
4962f87
VT-28545 Implement MGID Widget inside AMP Stories. VT-28604 - fix pv …
velichkin Dec 27, 2022
99fa3c7
VT-28545 Implement MGID Widget inside AMP Stories. Dismiss capping
velichkin Dec 28, 2022
42050be
VT-28545 Implement MGID Widget inside AMP Stories. VT-28614 Add cxurl…
velichkin Dec 28, 2022
134e51f
VT-28545 Implement MGID Widget inside AMP Stories. VT-28615 fix empty…
velichkin Dec 28, 2022
5003c75
Merge branch 'master' into VT-28545
velichkin Dec 28, 2022
7a93660
VT-28545 Implement MGID Widget inside AMP Stories. Fix tests
velichkin Dec 28, 2022
38c1252
VT-28545 Implement MGID Widget inside AMP Stories. Fix pr parameter
velichkin Dec 29, 2022
1eacdc6
Merge branch 'master' into VT-28545
velichkin Dec 29, 2022
1d2b6be
VT-28545 Implement MGID Widget inside AMP Stories. Fix pr parameter t…
velichkin Dec 29, 2022
db439dc
Merge branch 'master' into VT-28545
velichkin Jan 11, 2023
33dede7
VT-28545 Implement MGID Widget inside AMP Stories. Remove localStorag…
velichkin Jan 12, 2023
0ae7952
Merge branch 'master' into VT-28545
velichkin Jan 12, 2023
70b3303
Merge branch 'master' into VT-28545
velichkin Jan 24, 2023
3858385
VT-28545 Implement MGID Widget inside AMP Stories. Fix pvurl; hasown …
velichkin Jan 24, 2023
1c6c1fe
Merge branch 'master' into VT-28545
velichkin Jan 25, 2023
30c9da7
Merge branch 'master' into VT-28545
velichkin Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ads/_a4a-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ export function getA4ARegistry() {
'dianomi': () => true,
'doubleclick': () => true,
'fake': () => true,
'mgid': (win, adTag) => !adTag.hasAttribute('data-container'),
'nws': () => true,
'smartadserver': () => true,
'valueimpression': () => true,
Expand Down
5 changes: 5 additions & 0 deletions build-system/compile/bundles.config.extensions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,11 @@
"version": "0.1",
"latestVersion": "0.1"
},
{
"name": "amp-ad-network-mgid-impl",
"version": "0.1",
"latestVersion": "0.1"
},
{
"name": "amp-ad-network-nws-impl",
"version": "0.1",
Expand Down
1 change: 1 addition & 0 deletions build-system/test-configs/dep-check-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ exports.rules = [
'extensions/amp-ad-network-valueimpression-impl/0.1/amp-ad-network-valueimpression-impl.js->extensions/amp-a4a/0.1/amp-a4a.js',
'extensions/amp-ad-network-dianomi-impl/0.1/amp-ad-network-dianomi-impl.js->extensions/amp-a4a/0.1/amp-a4a.js',
'extensions/amp-ad-network-smartadserver-impl/0.1/amp-ad-network-smartadserver-impl.js->extensions/amp-a4a/0.1/amp-a4a.js',
'extensions/amp-ad-network-mgid-impl/0.1/amp-ad-network-mgid-impl.js->extensions/amp-a4a/0.1/amp-a4a.js',

// A4A impls importing amp fast fetch header name
'extensions/amp-ad-network-adsense-impl/0.1/amp-ad-network-adsense-impl.js->extensions/amp-a4a/0.1/signature-verifier.js',
Expand Down
167 changes: 167 additions & 0 deletions examples/amp-story/mgid.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,167 @@
<!doctype html>
<html amp lang="en">
<head>
<meta charset="utf-8">
<script async src="https://cdn.ampproject.org/v0.js"></script>
<script async custom-element="amp-story" src="https://cdn.ampproject.org/v0/amp-story-1.0.js"></script>
<script async custom-element="amp-story-auto-ads" src="https://cdn.ampproject.org/v0/amp-story-auto-ads-0.1.js"></script>
<meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1">
<link rel="canonical" href="mgid.html">
<style amp-boilerplate>body{-webkit-animation:-amp-start 8s steps(1,end) 0s 1 normal both;-moz-animation:-amp-start 8s steps(1,end) 0s 1 normal both;-ms-animation:-amp-start 8s steps(1,end) 0s 1 normal both;animation:-amp-start 8s steps(1,end) 0s 1 normal both}@-webkit-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-moz-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-ms-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-o-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}</style><noscript><style amp-boilerplate>body{-webkit-animation:none;-moz-animation:none;-ms-animation:none;animation:none}</style></noscript>
<link href="https://fonts.googleapis.com/css?family=Lilita+One&display=swap" rel="stylesheet">
<style amp-custom>
amp-story-page {
background: CadetBlue;
}

.container {
justify-content: center;
align-content: center;
}

.num {
text-align: center;
color: white;
font-size: 300px;
}
</style>
</head>

<body>
<amp-story standalone supports-landscape>
<amp-story-auto-ads>
<script type="application/json">
{
"ad-attributes": {
"type": "mgid",
"data-widget": 1392080
}
}
</script>

</amp-story-auto-ads>

<amp-story-page id="page-1">
<amp-story-grid-layer class="container" template="vertical">
<p class="num">1</p>
</amp-story-grid-layer>
</amp-story-page>

<amp-story-page id="page-2">
<amp-story-grid-layer class="container" template="vertical">
<p class="num">2</p>
</amp-story-grid-layer>
</amp-story-page>

<amp-story-page id="page-3">
<amp-story-grid-layer class="container" template="vertical">
<p class="num">3</p>
</amp-story-grid-layer>
</amp-story-page>

<amp-story-page id="page-4">
<amp-story-grid-layer class="container" template="vertical">
<p class="num">4</p>
</amp-story-grid-layer>
</amp-story-page>

<amp-story-page id="page-5">
<amp-story-grid-layer class="container" template="vertical">
<p class="num">5</p>
</amp-story-grid-layer>
</amp-story-page>

<amp-story-page id="page-6">
<amp-story-grid-layer class="container" template="vertical">
<p class="num">6</p>
</amp-story-grid-layer>
</amp-story-page>

<amp-story-page id="page-7">
<amp-story-grid-layer class="container" template="vertical">
<p class="num">7</p>
</amp-story-grid-layer>
</amp-story-page>

<amp-story-page id="page-8">
<amp-story-grid-layer class="container" template="vertical">
<p class="num">8</p>
</amp-story-grid-layer>
</amp-story-page>

<amp-story-page id="page-9">
<amp-story-grid-layer class="container" template="vertical">
<p class="num">9</p>
</amp-story-grid-layer>
</amp-story-page>

<amp-story-page id="page-10">
<amp-story-grid-layer class="container" template="vertical">
<p class="num">10</p>
</amp-story-grid-layer>
</amp-story-page>

<amp-story-page id="page-11">
<amp-story-grid-layer class="container" template="vertical">
<p class="num">11</p>
</amp-story-grid-layer>
</amp-story-page>

<amp-story-page id="page-12">
<amp-story-grid-layer class="container" template="vertical">
<p class="num">12</p>
</amp-story-grid-layer>
</amp-story-page>

<amp-story-page id="page-13">
<amp-story-grid-layer class="container" template="vertical">
<p class="num">13</p>
</amp-story-grid-layer>
</amp-story-page>

<amp-story-page id="page-14">
<amp-story-grid-layer class="container" template="vertical">
<p class="num">14</p>
</amp-story-grid-layer>
</amp-story-page>

<amp-story-page id="page-15">
<amp-story-grid-layer class="container" template="vertical">
<p class="num">15</p>
</amp-story-grid-layer>
</amp-story-page>

<amp-story-page id="page-16">
<amp-story-grid-layer class="container" template="vertical">
<p class="num">16</p>
</amp-story-grid-layer>
</amp-story-page>

<amp-story-page id="page-17">
<amp-story-grid-layer class="container" template="vertical">
<p class="num">17</p>
</amp-story-grid-layer>
</amp-story-page>

<amp-story-page id="page-18">
<amp-story-grid-layer class="container" template="vertical">
<p class="num">18</p>
</amp-story-grid-layer>
</amp-story-page>

<amp-story-page id="page-19">
<amp-story-grid-layer class="container" template="vertical">
<p class="num">19</p>
</amp-story-grid-layer>
</amp-story-page>

<amp-story-page id="page-20">
<amp-story-grid-layer class="container" template="vertical">
<p class="num">20</p>
</amp-story-grid-layer>
</amp-story-page>

</amp-story>
</body>

</html>
Loading