Skip to content

the metallb annotation actually in use is deprecated, support the new as well #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
majst01 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

the metallb annotation actually in use is deprecated, support the new as well #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
295971e
Prepare annotation migration
majst01 Apr 10, 2025
5c67d05
Merge branch 'master' into deprecated-address-pool
majst01 Jun 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/controllers/loadbalancer/loadbalancer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,7 @@
func (l *LoadBalancerController) acquireIP(ctx context.Context, service *v1.Service) (string, error) {
annotations := service.GetAnnotations()
addressPool, ok := annotations[constants.MetalLBSpecificAddressPool]
deprecatedAddressPool, deprecatedok := annotations[constants.DeprecatedMetalLBSpecificAddressPool]

Check failure on line 339 in pkg/controllers/loadbalancer/loadbalancer.go

View workflow job for this annotation

GitHub Actions / Docker Build 

declared and not used: deprecatedok (typecheck)

Check failure on line 339 in pkg/controllers/loadbalancer/loadbalancer.go

View workflow job for this annotation

GitHub Actions / Docker Build 

declared and not used: deprecatedAddressPool

Check failure on line 339 in pkg/controllers/loadbalancer/loadbalancer.go

View workflow job for this annotation

GitHub Actions / Docker Build 

declared and not used: deprecatedok) (typecheck)

Check failure on line 339 in pkg/controllers/loadbalancer/loadbalancer.go

View workflow job for this annotation

GitHub Actions / Docker Build 

declared and not used: deprecatedAddressPool

Check failure on line 339 in pkg/controllers/loadbalancer/loadbalancer.go

View workflow job for this annotation

GitHub Actions / Docker Build 

declared and not used: deprecatedok) (typecheck)

Check failure on line 339 in pkg/controllers/loadbalancer/loadbalancer.go

View workflow job for this annotation

GitHub Actions / Docker Build 

declared and not used: deprecatedAddressPool
if !ok {
if l.defaultExternalNetworkID == "" {
return "", fmt.Errorf(`no default network for ip acquisition specified, acquire an ip for your cluster's project and specify it directly in "spec.loadBalancerIP"`)
Expand Down
3 changes: 2 additions & 1 deletion pkg/resources/constants/constants.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ const (
ProviderName = "metal"

// FIXME this annotation is deprecated metallb.io should be used instead
MetalLBSpecificAddressPool = "metallb.universe.tf/address-pool"
DeprecatedMetalLBSpecificAddressPool = "metallb.universe.tf/address-pool"
MetalLBSpecificAddressPool = "metallb.io/address-pool"

IPPrefix = "metallb-"

Expand Down
Loading