chore: consolidate tsconfig presets #78
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Greptile Overview
Greptile Summary
This PR successfully consolidates TypeScript configuration across the monorepo by introducing a new
@tooling/tsconfig/apppreset and simplifying theinternal-packagepreset.Key Changes:
app.jsonpreset centralizing DOM libraries (ESNext,DOM,DOM.Iterable),noEmit, andallowImportingTsExtensionsfor all app configurationsinternal-package.jsonpreset to includenoEmitandallowImportingTsExtensions, removing emission-related options (declaration,declarationMap,emitDeclarationOnly,outDir)baseto the newapppreset, eliminating redundant configurationrootDirand other now-inherited optionsui,workflows) appropriately inlinelib: ["ESNext", "DOM", "DOM.Iterable"]The refactoring reduces configuration duplication (89 lines removed, 36 added) while maintaining type safety and build correctness. All app-specific configs now only contain their unique overrides (jsx, plugins, esModuleInterop), making the codebase more maintainable.
Confidence Score: 5/5
Important Files Changed
Sequence Diagram
sequenceDiagram participant Dev as Developer participant Apps as Apps (web, mobile, desktop, etc) participant Packages as Internal Packages participant AppPreset as @tooling/tsconfig/app participant PkgPreset as @tooling/tsconfig/internal-package participant Base as @tooling/tsconfig/base Dev->>AppPreset: Create new app.json preset Note over AppPreset: Includes: ESNext, DOM, DOM.Iterable<br/>noEmit, allowImportingTsExtensions Dev->>PkgPreset: Simplify internal-package.json Note over PkgPreset: Remove emission configs<br/>Add: noEmit, allowImportingTsExtensions Dev->>Apps: Update all app tsconfigs Apps->>AppPreset: extends @tooling/tsconfig/app AppPreset->>Base: extends base.json Note over Apps: Remove redundant: lib, noEmit,<br/>allowImportingTsExtensions Note over Apps: Keep only: jsx, esModuleInterop,<br/>plugins (as needed) Dev->>Packages: Update all package tsconfigs Packages->>PkgPreset: extends internal-package.json PkgPreset->>Base: extends base.json Note over Packages: Remove: rootDir, emission configs<br/>Inline DOM libs only where needed<br/>(ui, workflows)