Merge pull request #62 from Jalen-Stephens/jalen/pom-bug-fix

fixed pmd and checkstyle errors

Author: ikeschmack

src/main/java/dev/coms4156/project/metadetect/c2pa/C2paToolInvoker.java

@@ -52,37 +52,35 @@ public C2paToolInvoker(String c2paToolPath) {
 
 
 
-    /**
+  /**
    * Backwards-compatible wrapper used by existing code/tests.
-   *
    * Historically, the service used a plain JSON string "manifest" coming
    * from c2patool. We now normalize that into {@link C2paMetadata}, but
    * expose this helper for callers that still expect a String.
-   *
    * Contract:
    * - Never throws.
    * - Returns a JSON serialization of {@link C2paMetadata}.
    */
-    @Deprecated
-    public String extractManifest(File imageFile) {
-      C2paMetadata metadata = extractMetadata(imageFile);
+  @Deprecated
+  public String extractManifest(File imageFile) {
+    C2paMetadata metadata = extractMetadata(imageFile);
+    try {
+      ObjectMapper mapper = new ObjectMapper();
+      return mapper.writeValueAsString(metadata);
+    } catch (Exception e) {
+      String msg = "Failed to serialize C2PA metadata to JSON: " + e;
+      log.warn(msg, e);
+      C2paMetadata error = C2paMetadata.error(msg);
       try {
         ObjectMapper mapper = new ObjectMapper();
-        return mapper.writeValueAsString(metadata);
-      } catch (Exception e) {
-        String msg = "Failed to serialize C2PA metadata to JSON: " + e;
-        log.warn(msg, e);
-        C2paMetadata error = C2paMetadata.error(msg);
-        try {
-          ObjectMapper mapper = new ObjectMapper();
-          return mapper.writeValueAsString(error);
-        } catch (Exception inner) {
-          log.warn("Secondary failure serializing error C2PA metadata: {}", inner.toString());
-          // Last-resort JSON so callers never get null
-          return "{\"c2paErrorFlag\":1,\"c2paErrorMessage\":\"serialization failure\"}";
-        }
+        return mapper.writeValueAsString(error);
+      } catch (Exception inner) {
+        log.warn("Secondary failure serializing error C2PA metadata: {}", inner.toString());
+        // Last-resort JSON so callers never get null
+        return "{\"c2paErrorFlag\":1,\"c2paErrorMessage\":\"serialization failure\"}";
       }
     }
+  }
 
   /**
    * Executes the C2PA tool and converts its output into ML-ready metadata.
@@ -192,7 +190,7 @@ private C2paMetadata parseMetadataFromJson(String json) {
         // Resolve active manifest (preferred) or fall back to first manifest.
         JsonNode activeManifestField = root.get("active_manifest");
         String activeManifestId =
-            (activeManifestField != null && !activeManifestField.isNull())
+            activeManifestField != null && !activeManifestField.isNull()
                 ? activeManifestField.asText(null)
                 : null;
 

src/main/java/dev/coms4156/project/metadetect/service/AnalyzeService.java

@@ -193,7 +193,6 @@ public Dtos.AnalyzeCompareResponse compare(UUID leftImageId, UUID rightImageId)
   /**
    * Downloads the asset, runs C2PA, and finalizes the report.
    * Converts any thrown errors into a FAILED report with error JSON.
-   *
    * For C2PA specifically, hard failures are converted to a C2paMetadata
    * object with c2pa_errorFlag = 1, so the analysis flow is not broken.
    */
@@ -214,7 +213,7 @@ private void runExtractionAndFinalize(UUID analysisId, String storagePath) {
       // The details field now stores the C2PA metadata schema, not raw manifest JSON.
       markCompleted(analysisId, json, /*confidence*/ null);
 
-    } catch (java.io.IOException ioe) {
+    } catch (IOException ioe) {
       // IO-level failures (download, JSON serialization) are genuine failures.
       handleGenericFailure(analysisId, storagePath, ioe);
 
@@ -350,7 +349,7 @@ private void handleGenericFailure(UUID analysisId, String storagePath, Exception
       var errorObj = new java.util.LinkedHashMap<String, Object>();
       errorObj.put("error", errMsg);
       // optionally include more context:
-      // errorObj.put("storagePath", storagePath);
+      errorObj.put("storagePath", storagePath);
       String errorJson = objectMapper.writeValueAsString(errorObj);
       markFailed(analysisId, errorJson);
     } catch (Exception jsonEx) {