Allow frozenset in attributes parameter of clean function

[ashrub-holvi]

Now it's dict[str, set[str]], and attempt to use frozenset will return

TypeError: argument 'attributes': 'frozenset' object cannot be converted to 'PySet'

but IMO using frozenset is a good practice, because if data is immutable good to use immutable type, for example allowed attributes can be defined in configuration and it's safer to use immutable type.

[ashrub-holvi]

also MappingProxyType can be allowed instead of dictionary

[adamchainz]

The TypeError comes from PyO3. It’s not clear to me from the PyO3 arg docs if there’s an easy way to allow all kinds of mappings or sets and have PyO3 convert them.

[messense]

Adding support for frozenset in PyO3/pyo3#3632

[ashrub-holvi]

Thank you! Do you think it's possible to add support of MappingProxyType? As I understand it's only way to have read-only dictionaries without adding third-party libraries.

[messense]

Thank you! Do you think it's possible to add support of MappingProxyType? As I understand it's only way to have read-only dictionaries without adding third-party libraries.

Should be possible now that PyO3/pyo3#4644 is merged, will try to add support for it in nh3 later.

[ericscales]

I see the change was merged, but still unable to add - perhaps this has to do with the MappingProxyType?

Argument of type "dict[str, frozenset[str]]" cannot be assigned to parameter "attributes" of type "Dict[str, Set[str]] | None" in function "clean" Type "dict[str, frozenset[str]]" is not assignable to type "Dict[str, Set[str]] | None" "dict[str, frozenset[str]]" is not assignable to "Dict[str, Set[str]]" Type parameter "_VT@dict" is invariant, but "frozenset[str]" is not the same as "Set[str]" Consider switching from "dict" to "Mapping" which is covariant in the value type "dict[str, frozenset[str]]" is not assignable to "None"