Skip to content

Commit 2bfc619

Browse files
authored
Minimal fix: set camera position (#431)
* set camera * use max dimension
1 parent 332d07d commit 2bfc619

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

cellpack/autopack/upy/simularium/simularium_helper.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1328,7 +1328,9 @@ def writeToFile(self, file_name, bb, recipe_name, version):
13281328
n_subpoints[t][n] = 0
13291329
n += 1
13301330

1331-
camera_z_position = box_size[2] if box_size[2] > 10 else 100.0
1331+
# use max dimension to make sure camera captures entire scene
1332+
max_box_dimension = max(box_size)
1333+
camera_z_position = max_box_dimension * 2.5
13321334
converted_data = TrajectoryData(
13331335
meta_data=MetaData(
13341336
box_size=np.array(box_size),

cellpack/bin/simularium_converter.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -390,7 +390,7 @@ def main():
390390
converter.fill_in_empty_fiber_data(time_point_index)
391391
if converter.debug:
392392
print("SUBPOINTS LENGTH", len(converter.subpoints[time_point_index]))
393-
camera_z_position = box_size[2] if box_size[2] > 10 else 100.0
393+
camera_z_position = box_size[2] * 1.5
394394
converted_data = TrajectoryData(
395395
meta_data=MetaData(
396396
box_size=np.array(box_size),

examples/recipes/v2/spheres_in_a_box.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
[
1313
1000,
1414
1000,
15-
1500
15+
1000
1616
]
1717
],
1818
"objects": {

0 commit comments

Comments
 (0)