Merged
Conversation
Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
- Update `MapScreen` to pass layout modifiers to `MapView`. - Remove internal `Scaffold` from Google Maps `MapView` implementation. - Reformat `MapView.kt` for improved code style and readability. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4696 +/- ##
=====================================
Coverage 8.12% 8.12%
=====================================
Files 64 64
Lines 2499 2499
Branches 289 289
=====================================
Hits 203 203
Misses 2264 2264
Partials 32 32 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to layout handling and code consistency in the map-related UI components, with a focus on better window insets management, safer padding, and composable modifier usage. The changes also streamline string formatting and enhance the maintainability of the codebase.
Layout and window insets improvements:
recalculateWindowInsetsandsafeDrawingPaddingto theNavHostmodifier inMainScreento better handle system window insets and ensure content is safely padded. [1] [2]MapViewcomposables (both F-Droid and Google versions) to accept amodifierparameter, enabling more flexible layout composition and consistent use of modifiers for padding and sizing. [1] [2] [3] [4] [5] [6]String formatting improvements:
getStringandgetStringSuspendextension functions to separate string pattern retrieval from formatting, ensuring correct formatting only when arguments are provided. [1] [2]Code consistency and cleanup:
GoogleMapusage, and removed unnecessaryScaffoldwrapper in the Google Map implementation for cleaner code. [1] [2] [3] [4]These changes collectively improve UI reliability across devices, make the code more maintainable, and ensure correct string handling.