Skip to content

⚡ Bolt: Optimize DependencyTools string operations #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
google-labs-jules wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

⚡ Bolt: Optimize DependencyTools string operations #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 21 additions & 19 deletions resolver/src/main/java/net/evendanan/bazel/mvn/api/DependencyTools.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package net.evendanan.bazel.mvn.api;

import java.util.Locale;
import net.evendanan.bazel.mvn.api.model.Dependency;
import net.evendanan.bazel.mvn.api.model.MavenCoordinate;

Expand All @@ -9,44 +8,47 @@ public class DependencyTools {
public static final DependencyTools DEFAULT = new DependencyTools();

private static String normalize(String name) {
return name.replaceAll("[+.-]", "_");
StringBuilder sb = new StringBuilder(name.length());
for (int i = 0; i < name.length(); i++) {
char c = name.charAt(i);
if (c == '+' || c == '.' || c == '-') {
sb.append('_');
} else {
sb.append(c);
}
}
return sb.toString();
}

public final String mavenCoordinates(Dependency dependency) {
return mavenCoordinates(dependency.mavenCoordinate());
}

public String mavenCoordinates(MavenCoordinate mavenCoordinate) {
return String.format(
Locale.ROOT,
"%s:%s:%s",
mavenCoordinate.groupId(),
mavenCoordinate.artifactId(),
mavenCoordinate.version());
return mavenCoordinate.groupId()
+ ":"
+ mavenCoordinate.artifactId()
+ ":"
+ mavenCoordinate.version();
}

public final String repositoryRuleName(Dependency dependency) {
return repositoryRuleName(dependency.mavenCoordinate());
}

public String repositoryRuleName(MavenCoordinate mavenCoordinate) {
return String.format(
Locale.ROOT,
"%s__%s__%s",
normalize(mavenCoordinate.groupId()),
normalize(mavenCoordinate.artifactId()),
normalize(mavenCoordinate.version()));
return normalize(mavenCoordinate.groupId())
+ "__"
+ normalize(mavenCoordinate.artifactId())
+ "__"
+ normalize(mavenCoordinate.version());
}

public final String targetName(Dependency dependency) {
return targetName(dependency.mavenCoordinate());
}

public String targetName(MavenCoordinate mavenCoordinate) {
return String.format(
Locale.ROOT,
"%s__%s",
normalize(mavenCoordinate.groupId()),
normalize(mavenCoordinate.artifactId()));
return normalize(mavenCoordinate.groupId()) + "__" + normalize(mavenCoordinate.artifactId());
}
}