Consider local-ip hosts as local

[binokaryg]

As announced in the release 3.2.0:

To detect accidental overwrites, cht-conf will generate two files - .snapshots/remote.json and .snapshots/local.json. These store the last known configuration on the server. The remote.json file should be commited with your configuration changes, and local.json should be added to the .gitignore since everyone's local environment is different. If changes are made to the configuration on the server using cht-conf or the App Management webapp without committing the remote.json file to your config repo, and then subsequently pulling the changes, then any attempt to upload configuration changes will be notified about the risk and prompted to either overwrite or cancel.

However, we only consider localhost as local.

cht-conf/src/lib/warn-upload-overwrite.js

Lines 29 to 31 in dae31f9

	if (parsed.hostname === 'localhost') {
	return 'local.json';
	}

With docker-helper & nginx-local-ip, now we can have local instances like this: https://192-168-0-3.local-ip.medicmobile.org:8443.

We might want to consider them as local so that remote.json is reserved for remote instances.

[jkuester]

🤔 Is there any particular reason to store snapshots of just local/remote instead of having a separate snapshot for each URL that is targeted?

The main difference I can think of when it comes to a normal app dev workflow is that currently if there is remote dev/prod instances, then the remote snapshot is getting reused for both. Perhaps that leads to some desirable outcome/behavior? Otherwise, I feel like it would be fine (maybe even useful) to have separate snapshots for each).

Either way, I agree that local-ip snapshots should probably not override the remote.json.

[santhosh-7777]

Hi @binokaryg, I’d like to work on this issue.
From the description, it seems we need to treat local-ip hosts as local (similar to localhost) when determining snapshot files. I can look into updating the logic accordingly.
Could you please assign this to me?

[santhosh-7777]

Hi @binokaryg @andrablaj , I've updated the logic in warn-upload-overwrite.js to treat local-ip hosts as local, similar to localhost. Would appreciate a review when you get a chance. Thanks!