From 675fca6e17c8aca2bdae1e8b0fcf4eebc8da842c Mon Sep 17 00:00:00 2001 From: Tobias Klauser Date: Tue, 14 Oct 2025 13:28:22 +0200 Subject: [PATCH] Simplify IPv4 address validation in NewPacket Use netip.Addr.Is4 to validate both source and destination IP. Also drop the redundant check for an invalid IP. netip.Addr.Is4 will return false for an invalid netip.Addr. --- packet.go | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/packet.go b/packet.go index 8c61912..fbe9129 100644 --- a/packet.go +++ b/packet.go @@ -93,13 +93,8 @@ func NewPacket(op Operation, srcHW net.HardwareAddr, srcIP netip.Addr, dstHW net return nil, ErrInvalidHardwareAddr } - // Validate IP addresses to ensure they are IPv4 addresses, and - // correct length - var invalidIP netip.Addr - if !srcIP.IsValid() || !srcIP.Is4() { - return nil, ErrInvalidIP - } - if !dstIP.Is4() || dstIP == invalidIP { + // Validate IP addresses to ensure they are IPv4 addresses. + if !srcIP.Is4() || !dstIP.Is4() { return nil, ErrInvalidIP }