Skip to content

⚡ Optimize getGuildMembers to avoid object allocation #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
google-labs-jules wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

⚡ Optimize getGuildMembers to avoid object allocation #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion modules/GuildManager/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@
<dependency>
<groupId>me.clip</groupId>
<artifactId>placeholderapi</artifactId>
<version>2.11.1</version>
<version>2.11.6</version>
<scope>provided</scope>
</dependency>
<dependency>
Expand All @@ -120,6 +120,12 @@
<version>5.6.0-SNAPSHOT</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<version>4.13.2</version>
<scope>test</scope>
</dependency>
</dependencies>


Expand Down
25 changes: 19 additions & 6 deletions modules/GuildManager/src/main/java/com/mcatk/guildmanager/sql/SQLManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,10 @@
import com.mcatk.guildmanager.models.Member;

import java.sql.*;
import java.util.AbstractList;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;

public class SQLManager {
private Connection connection;
Expand All @@ -23,6 +25,10 @@ private SQLManager() {
guilds = getAllGuildsFromSQL();
}

protected SQLManager(HashMap<String, Guild> guilds) {
this.guilds = guilds;
}

private void connectMySQL() {
String ip = GuildManager.getPlugin().getConfig().getString("mysql.ip");
String databaseName = GuildManager.getPlugin().getConfig().getString("mysql.databasename");
Expand Down Expand Up @@ -142,12 +148,19 @@ public void removeMember(String playerID, String guildID) {
}
}

public ArrayList<String> getGuildMembers(String id) {
ArrayList<String> list = new ArrayList<>();
for (Member m : guilds.get(id).getMembers()) {
list.add(m.getId());
}
return list;
public List<String> getGuildMembers(String id) {
final List<Member> members = guilds.get(id).getMembers();
return new AbstractList<String>() {
@Override
public String get(int index) {
return members.get(index).getId();
}

@Override
public int size() {
return members.size();
}
};
}

public ArrayList<String> getGuildAdvancedMembers(String id) {
Expand Down
56 changes: 56 additions & 0 deletions modules/GuildManager/src/test/java/com/mcatk/guildmanager/sql/SQLManagerBenchmarkTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
package com.mcatk.guildmanager.sql;

import com.mcatk.guildmanager.models.Guild;
import com.mcatk.guildmanager.models.Member;
import org.junit.Test;

import java.lang.reflect.Field;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;

public class SQLManagerBenchmarkTest {

@Test
public void testBenchmark() throws Exception {
// Setup
HashMap<String, Guild> guilds = new HashMap<>();
String guildId = "test_guild";
Guild guild = new Guild();
guild.setId(guildId);

ArrayList<Member> members = new ArrayList<>();
int memberCount = 1000;
for (int i = 0; i < memberCount; i++) {
members.add(new Member("player_" + i, guildId, 0, false));
}
guild.setMembers(members);
guilds.put(guildId, guild);

// Inject into SQLManager
SQLManager instance = new SQLManager(guilds);
Field f = SQLManager.class.getDeclaredField("instance");
f.setAccessible(true);
f.set(null, instance);

// Warmup
for (int i = 0; i < 10000; i++) {
SQLManager.getInstance().getGuildMembers(guildId);
}

// Benchmark
long start = System.nanoTime();
int iterations = 100000;
for (int i = 0; i < iterations; i++) {
List<String> result = SQLManager.getInstance().getGuildMembers(guildId);
if (result.size() != memberCount) {
throw new RuntimeException("Size mismatch");
}
}
long end = System.nanoTime();

double durationMs = (end - start) / 1_000_000.0;
System.out.println("Benchmark finished in " + durationMs + " ms for " + iterations + " iterations.");
System.out.println("Average time per call: " + (durationMs / iterations) + " ms");
}
}