wxSheetSplitter initializes twice (leading to assert...)

[GWRon]

Issue:
Seems the wxSheetSplitter is initialized twice - which it shouldn't.

example:
Compile "samples/sheet.bmx" and see the assert live.

Details:
https://www.syntaxbomb.com/index.php/topic,5058.msg21321.html#msg21321

Side note:
While looking through the generated C-code I saw this:
struct wx_wxsheet_wxSheetSplitter_obj* bbt_sheetSplitter=(struct wx_wxsheet_wxSheetSplitter_obj*)wx_wxsheet_wxSheetSplitter.m_Create_TwxWindowiiiiii((struct wx_wxsheet_wxSheetSplitter_obj*)((struct wx_wxsheet_wxSheetSplitter_obj*)bbObjectNew((BBClass *)&wx_wxsheet_wxSheetSplitter)),(struct wx_wxwindow_wxWindow_obj*)((struct wx_wxwindow_wxWindow_obj*)bbObjectDowncast((BBOBJECT)bbt_splitter,(BBClass*)&wx_wxwindow_wxWindow)),-1,0,0,-1,-1,768);
Which seems to be ... something like a cast of something already casted into the right form. Just a matter of missing "optimization" (A does not know B and they just follow their rules).

[GWRon]

Cut down example:

SuperStrict

Framework wx.wxApp
Import wx.wxSheet
Import wx.wxFrame

New GridApp.run()


Type GridApp Extends wxApp

	Method OnInit:Int()

		Local frame:GridFrame = GridFrame(New GridFrame.Create(Null, -1, "wxSheet example"))

		frame.SetSize(800, 600)
		frame.show()

		Return True

	End Method

End Type


Type GridFrame Extends wxFrame

	Field grid:wxSheet


	Method OnInit:Int()
		Local splitter:wxSplitterWindow = New wxSplitterWindow.Create(Self, wxID_ANY)
		splitter.SetMinimumPaneSize(20)
		splitter.SetSashGravity(0.9)

		' To use the splitter simply create one, Then your sheet as a child
		' And initialize the splitter with the sheet.
'here it fails
		Local sheetSplitter:wxSheetSplitter = New wxSheetSplitter.Create(splitter, -1, 0, 0)

		grid = New wxSheet.Create( sheetSplitter, -1, 0, 0)

		sheetSplitter.Initialize(grid)

		' this will create a grid And, by Default, an associated grid
		' table For strings
		grid.CreateGrid( 0, 0 )
		grid.AppendRows(100)
		grid.AppendCols(100)

		Centre()
	End Method
End Type

[GWRon]

I adjusted wx.mod/include/wx/containr.h to output some logging stuff:

    wxControlContainerBase()
    {
		wxSafeShowMessage( wxT("LOG"), wxT("wxControlContainerBase"));
        m_winParent = NULL;

        // By default, we accept focus ourselves.
        m_acceptsFocusSelf = true;

        // But we don't have any children accepting it yet.
        m_acceptsFocusChildren = false;

        m_inSetFocus = false;
        m_winLastFocused = NULL;
    }
    virtual ~wxControlContainerBase() {}

    void SetContainerWindow(wxWindow *winParent)
    {
		wxSafeShowMessage( wxT("LOG"), wxT("SetContainerWindow"));
        wxASSERT_MSG( !m_winParent, wxT("shouldn't be called twice") );

        m_winParent = winParent;
    }

I also prepented two debug lines "before" and "after" before and after the creation of the wxSheetSplitter (see code above...).

		print "before creation"
		Local sheetSplitter:wxSheetSplitter = New wxSheetSplitter.Create(splitter, -1, 0, 0)
		print "after creation"

Output is:

./bmk makeapp -g x64 -t gui -r -x "/home/ronny/Arbeit/Programmieren/Tools/BlitzMaxNG/mod/wx.mod/samples/sheet_short.bmx"
[100%] Linking:sheet_short
Executing:sheet_short
LOG: wxControlContainerBase
LOG: SetContainerWindow
before creation
LOG: wxControlContainerBase
LOG: SetContainerWindow
LOG: SetContainerWindow
Trace/breakpoint trap

(end is a "stop" on the assert-window-dialogue).
I am not sure how to print out a class name of the instance within "wxControlContainerBase()" (->GetClassInfo() or CLASSINFO(&this) does not work).

If it was the same instance then it really gets initialized two times. If it was so then the error would lead to a window earlier (before "before creation"). Maybe it helps limiting what possibly happens here.

[GWRon]

Added some more debug information and output got this:

[100%] Linking:sheet_short
Executing:sheet_short
LOG: wxControlContainerBase
LOG: wxNavigationEnabled
LOG: SetContainerWindow
before creation
LOG: wxControlContainerBase
LOG: wxNavigationEnabled
LOG: SetContainerWindow
LOG: wxSheetSplitter::Init
LOG: SetContainerWindow
Trace/breakpoint trap

So what happens?
wxControlContainerBase() is executed and sets up wxNagivationEnabled() which calls SetContainerWindow (the first time).
Then the splitter calls its Init and this tries to call another SetContainerWindow - leading to above's assert.

[GWRon]

@woollybah
Were you able to replicate it? I am not sure if this is desired behaviour (wxwidgets initializing this stuff in two spots of the source code) or if BCC-NG is mixing up something (race condition like). As I cannot get wxMax run with vanilla on my 64 bit machines (nor somehow on my 32 bit variants - as the module then spits out errors) I cannot check if it is a vanilla or NG problem - or a wxmax thingy.