A few module errors I'm running into...

[DruggedBunny]

Hi Brucey & co, hope you're well.

I'm messing about with OpenGL and was talking to AI about getting a GLFW-init'd GL ES 2.0 context to use the Angle DLLs (trying to replicate what Mark had done with Monkey2), more out of interest than anything. (Revisiting my attempts at a simple 3D engine.)

It told me to build GLFW with EGL instead of WGL, and I tracked down mod\glfw.mod\glfw.mod\source.bmx, which I've hacked like so in the vague hope it'll be that simple (or just require a few tweaks):

'Import "glfw/src/wgl_context.c"
Import "glfw/src/egl_context.c"

But this caused quite a few build errors on using MaxIDE's Build Modules, eg.

mod\b3d.mod\assimp.mod\assimp.bmx:

Import Openb3dlibs.Assimplib

Seems this should be:

Import b3d.Assimplib

(There is no Openb3dlibs as far as I can see.)

And similar in mod\b3d.mod\newtondynamics.mod\newtondynamics.bmx

(There might have been 1 or 2 more.)

I've also run into mod\bah.mod\sstream.mod\sstream.bmx giving a stat_ () error, where I had to change from:

	Local Mode:Int,mtime:Int,ctime:Int
        
	If stat_( path,Mode,size,mtime,ctime )=0

... to:

	Local Mode:Int,mtime:Int,ctime:Int,atime:Int
	
	If stat_( path,Mode,size,mtime,ctime,atime )=0

(Missing 'atime' in both lines. Interestingly, FileSize in FileSystem uses a full atime call.)

My current build error is this in mod\bah.mod\dboracle.mod\dboracle.bmx:

		Local strings:Byte Ptr[]
		Local blobs:Byte Ptr[]
		Local dates:Byte Ptr[]

		If values Then
			Local paramCount:Int = bindCount

			params = New Byte Ptr[paramCount]
			strings = New Short Ptr[paramCount]

Notice strings is defined as Byte Ptr[] but is being assigned a short pointer. Not sure if that should work, but I get 'Unable to convert from Short Ptr Array to Byte Ptr Array' (bcc says it's 0.136.)

Converting the assignment to Byte Ptr seems to get past that, but gives, later in same file:

Unable to find overload for freemem2(Byte Ptr Array). Argument #1 is "Byte Ptr Array" but declaration is "Short Ptr Array".

Changing the definition to Short Ptr instead seems to work, but now getting 'Can't find interface for module 'pub.libpng'' in:

mod\bah.mod\magick.mod\source.bmx

Just documenting these while I can! Suspect I'm in a bit of a rabbit hole but pushing onwards!

[DruggedBunny]

mod\bah.mod\magick.mod\source.bmx:

Changed:

Import Pub.libpng

... to:

Import image.png

mod\bah.mod\gdal.mod\source.bmx:

Changed:

Import Pub.Libjpeg
Import Pub.Libpng

... to:

Import image.jpg
Import image.png

Comes back to this file after a few of the fixes below...

Changed:

Import BaH.libcurl
... to:

Import net.libcurl

mod\bah.mod\taglib.mod\taglib.bmx:

All instances of:

Method ObjectEnumerator ()

So...

TTLFLACPictureList.ObjectEnumerator
TTLOggFieldListMap.ObjectEnumerator
TTLMP4ItemListMap.ObjectEnumerator
TTLMP4CoverArtList.ObjectEnumerator

... each use 3 instances of an Enum variable conflicting with keyword Enum -- changed to _enum.

Currently looking for 'wx.wxZipOutputStream', not found by mod\bah.mod\xlwriter.mod\xlwriter.bmx:

WIP!

[DruggedBunny]

After installing wx mod...

mod\bah.mod\filesystemex.mod\filesystemex.bmx:

Changed:

Function FileMode:Int(path:String)
	path = RealPath(path)
	Local Mode:Int, mtime:Int, ctime:Int
?bmxng
	Local size:Long
?Not bmxng
	Local size:Int
?
	If stat_( path,Mode,size,mtime,ctime ) Return -1
	Return Mode & 511
End Function

... to:

Function FileMode:Int(path:String)
	path = RealPath(path)
	Local Mode:Int, mtime:Int, ctime:Int, atime:Int
?bmxng
	Local size:Long
?Not bmxng
	Local size:Int
?
	If stat_( path,Mode,size,mtime,ctime,atime ) Return -1
	Return Mode & 511
End Function

(Pesky atime again.)

mod\bah.mod\curses.mod\core.bmx:

Changed TConsoleSystemDriver:

	Method New()
		NativeDriver=brl.System.Driver
	End Method

... to:

	Method New()
		NativeDriver=brl.System._Driver ' underscore
	End Method

EDIT: Actually, nope to that! It's private... will probably fiddle later.

mod\brl.mod\system.mod\driver.bmx:

Private
Global _Driver:TSystemDriver
Public

Lunch break over!

[DruggedBunny]

OK, so in mod\brl.mod\system.mod\driver.bmx:

TConsoleSystemDriver.New:

Changed:

brl.System.Driver

... to:

brl.System.SystemDriver ()

TCDKDriver.New:

... and:

brl.System.Driver = New TConsoleSystemDriver

... to:

InitSystemDriver New TConsoleSystemDriver

... but that now gives:

"Can't create instance of type TConsoleSystemDriver due to abstract Method TSystemDriver.Name:String()."

Bit lost on that one!

Type TSystemDriver

	Method Name:String() Abstract
	
[...]

	Method ToString:String() Override
		Return Name()
	End Method

End Type

[DruggedBunny]

Hacked in:

Type TConsoleSystemDriver Extends TSystemDriver

[...]

	Method Name:String()
		Return Self.Name ()
	End Method

End Type

... but that now gives "Can't create instance of type TConsoleSystemDriver due to abstract Method TSystemDriver.DesktopWidth:Int(display:Int)."

I see a lot more Abstract methods in TSystemDriver, but TConsoleSystemDriver does have (empty, non-returning) methods defined for these, including DesktopWidth ()... will try adding returns later!

[GWRon]

Where is TConsoleSystemDriver defined in?

brl.mod/system.mod/driver.bmx is superstrict
brl.mod/system.mod/system.bmx is strict
... dunno what your is - but maybe this has an impact?

Basically it should be enough to have working methods in your implementation which the base has set as "abstract".

[DruggedBunny]

Yeah, should be in "mod\brl.mod\system.mod\driver.bmx" I think... I did get past that, built quite a lot afterwards, but my train has hit the buffers now, will post once I can piece it all together! (After work.)

[DruggedBunny]

Up-front disclaimer: I have exactly enough knowledge to be dangerous! Note that none of this is a real problem for me, was just trying something out and, well, you see what happened... so documented! Feel free to close/ignore, etc, but might be useful.

OK, so I got past the DesktopWidth, etc, Abstract errors by changing as below -- sorry, this was in mod\bah.mod\curses.mod\core.bmx:

Type TConsoleSystemDriver Extends TSystemDriver

	[...]

	Method DesktopWidth:Int()
	End Method
	
	Method DesktopHeight:Int()
	End Method

	Method DesktopDepth:Int()
	End Method

	Method DesktopHertz:Int()
	End Method

... to:

Type TConsoleSystemDriver Extends TSystemDriver

	[...]
	
	Method DesktopWidth:Int(display:Int)
		Return 0
	End Method
	
	Method DesktopHeight:Int(display:Int)
		Return 0
	End Method

	Method DesktopDepth:Int(display:Int)
		Return 0
	End Method

	Method DesktopHertz:Int(display:Int)
		Return 0
	End Method

(No idea what effect returning 0 would have!)

mod\b3d.mod\assimplib.mod\assimplib.bmx:

Needed:

Module Openb3dlibs.Assimplib

... changing to:

Module b3d.Assimplib

mod\b3d.mod\assimp.mod\assimp.bmx:

Import Openb3d.B3dglgraphics

... to:

Import b3d.B3dglgraphics

mod/bah.mod/libtcod.mod/text.bmx:

Compile Error: Type 'td3d7imageframe' not found

Changed as below (d3d7 to d3d9, which seems to be default -- d3d7 seems to be ignored), from:

SuperStrict

Import BRL.GLMax2D
?win32
Import BRL.d3d7max2d
?

... to:

SuperStrict

Import BRL.GLMax2D
?win32
Import BRL.d3d9max2d
?

... and:

Type TCODFont

		[...]
		
	Global GLframe:TGLImageFrame
	?win32
	Global DXframe:TD3D7ImageFrame
	?

Latter var changed to:
Global DXframe:TD3D9ImageFrame

[...]

and...

	Method Draw(i:Int, X:Float, Y:Float, force:Int = False, cb:Int = -1)

	[...]
		
		If isGL < 0 Or TCOD_REFRESH_IMAGE Then
			
		[...]
			
		?win32
			Else
				isGL = False
				DXframe = TD3D7ImageFrame(Image.Frame(0))
		?

Latter changed:

DXframe = TD3D9ImageFrame(Image.Frame(0))

[...]

And had to hack out this line:

			?win32
			Else
				'DXframe.setUV(u0[curchar], v0[curChar], u1[curChar], v1[curChar])
				DXframe.Draw(0, 0, fontWidth, fontHeight, X, Y, 0, 0, 1, 1)
			?
			End If

(No setUV in d3d9 frame.)

mod/bah.mod/cegui.mod/cegui.bmx:

Compile Error: Unable to convert from Void to Int.

... comes from the method return function bmx_cegui_etc:

Type TCECombobox Extends TCEWindow

[...]

	Method getItemIndex:Int(item:TCEListboxItem)
		Return bmx_cegui_combobox_getitemindex(objectPtr, item.objectPtr)
	End Method

Amended the definition in mod\bah.mod\cegui.mod\common.bmx:

From:

Function bmx_cegui_combobox_getitemindex(handle:Byte Ptr, item:Byte Ptr)

... to:

Function bmx_cegui_combobox_getitemindex:Int(handle:Byte Ptr, item:Byte Ptr)

(Might have been resolved with Strict/Superstrict?)

mod/wx.mod/wxmax2d.mod/wxmax2d.bmx:

Compile Error: Overriding method does not match any overridden method. (Detail: Return type is "Int", expected "Void". You may have Strict type overriding SuperStrict type.)

Changed to SuperStrict and changed some voids to Ints as they appeared on next couple of builds.

mod/wx.mod/wxmax2d.mod/wxmax2d.bmx:

Compile Error: Can't create instance of type TwxMax2DDriver due to abstract Method TGraphicsDriver.AttachGraphics:TGraphics(widget:Byte Ptr,flags:Long).

TGraphicsDriver is in mod\brl.mod\graphics.mod\graphics.bmx -- includes:

Method AttachGraphics:TGraphics( widget:Byte Ptr,flags:Long ) Abstract

... the Abstract extended version in wxmax2d.bmx being:

Type TwxMax2DDriver Extends TMax2DDriver

	Field ix#,iy#,jx#,jy#

	[...]
	
?bmxng
	Method AttachGraphics:TMax2DGraphics( widget:Byte Ptr ,flags:Int )
?Not bmxng
	Method AttachGraphics:TMax2DGraphics( widget:Int ,flags:Int )
?
		Local g:TwxGraphics=wxGraphicsDriver().AttachGraphics( widget,flags )
		If g Return TMax2DGraphics.Create( g,Self )
	End Method

...

... which looks OK to me... so I'm finally stuck! I can't see what's preventing this from working -- seems to be implemented and defined as needed, but I may be missing some subtlety.

Not sure how much of this will be down to me changing WGL to EGL right at the start, or how much more would be dug up after fixing this error (or what I'd have once finally built), but seems a fair bit could prevent a 'Build All Modules' now, so might be worth a review anyway! I've only done what seems to move along the builds...

[DruggedBunny]

... with apologies!