Should Nodes be Structs

[JakeZw]

With Nodes being common in UFF files, and nodes having three coordinates, I am wondering if they should be structs when in a Julia Dataset? Something along the line of:

`julia> struct NodeN{T <: AbstractFloat}
x::T
y::T
z::T
end

julia> n = Node(1.0, 2.3, 5.6)
Node{Float64}(1.0, 2.3, 5.6)`

[maucejo]

I think it is a matter of taste. Actually, I think that if we want to be consistent between dataset15 and 2411, we should convert coords in dataset 15 into a matrix. This is what I will do in the next release. The question we have to ask is "How this structure can be used?". I personally use the nodes information in Meshes.jl, where a node is actually a Point structure.

My opinion is to keep things simple ;)

[JakeZw]

I am not sure what your procedure in testing is? Can you walk me through that? Jake

[maucejo]

There is no formal testing procedure. What I do is as follows:

1. I create a sample containing only a given dataset. It is actually an extract of a real dataset.
2. I manually check that all the fields are filled correctly
3. Finally, use writeuff as an indirect means of validation

I didn't find a good way of implementing unit test (even if step 2 is a kind of unit test).

[maucejo]

I propose to close this issue, since I activated Github discussions for the repo.