Modifications to unit conversion helper functions#16
Closed
JakeZw wants to merge 6 commits intomaucejo:mainfrom
Closed
Modifications to unit conversion helper functions#16JakeZw wants to merge 6 commits intomaucejo:mainfrom
JakeZw wants to merge 6 commits intomaucejo:mainfrom
Conversation
Contributor
Author
|
put for loop in convert_to_si!(ds) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified the helper functions to assume a dataset164 as coming before any of the datasets to be converted. This is the normal layout for universal files so is a reasonable assumption. If it is not present in the array of datasets, the user can add it with a pushfirst!(ds164) command.