Skip to content

Question: Make ScreenshotParams clone-able or pass by ref #253

@JuxhinDB

Description

@JuxhinDB

Have a use-case currently where I need to use the same ScreenshotParams to handle screenshots for multiple pages in different branches. As it stands, I need to re-declare the params for each branch as fn screenshot moves ScreenshotParams. Quick-fix would be to derive Clone, and alternatively we could avoid consuming the screenshot params. Wanted to get some feedback here, if so I can open a PR with the preferred approach.

Also, thank you for the great library! Using it to power some parts of Have I Been Squatted.

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind:featureA request, idea or new functionalitytopic:interfaceRelated to the interface exposed to the user

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions