Skip to content

Improving this library #51

@ghost

Description

Hi @mattmccray,

Thank you so much for writing this library. This is much faster & more true-to-spec than the liquid-node project.

I have a few improvements in mind I'd like to work on:

  1. Remove extending native JS objects. This has been reported in Extending native JavaScript objects is a bad practice #47
  2. Make tests run in node using a Mocha runner.
  3. Switch the Rhino runner with a PhantomJS one.
  4. Move to a require-based system for both Node & browser.
  5. Publishing the library in NPM.

I see that @stewartknapman has done quite a bit of work on item 4. That could be a good starting point.

What're your thoughts on this?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions