Saving discs problems?

[pjmi1]

Accessing google drive doesn't work (now)

In menu Discs/From Google Drive
"Load or create disc from your Google Drive account" / create file just gives this error:
Error: Create failed: TypeError: undefined is not an object (evaluating 'this.gapi.client')
(on Safari on MacOS)

And on Google Chrome on MacOS:
Error: Create failed: TypeError: Cannot read properties of undefined (reading 'client')

Also, the option to "Download Drive 0 image as SSD/DSD" doesn't seem to do anything.

Please help!

[mattgodbolt]

Thanks for the note! I'm not seeing that in Google Chrome. I did change a bunch of stuff about the way we load google's APIs (as they deprecated the way we used to do it).

This is what I get:

Screencast.From.2025-05-14.08-19-58.webm

Similarly when I select "download drive 0" I get a file in my downloads:

Can you try one or other in Firefox? I'm doing that now myself too to see if it's something I can repro there!

[mattgodbolt]

Firefox on Linux - downloading ssd:

and similarly worked for gdrive (once I did all the google login stuff)

Do you have any ad blockers?

[pjmi1]

Thanks for the quick response, Matt.

Just to clarify: I don't think I tried either of these jsbeeb file functions in a while, if ever, so you having made recent changes might not be the reason for my problems.

On Chrome, the "Discs/download drive 0 image as SSD/DSD" DOES WORK (I forgot to test that on Chrome).
I Did have MacOS Safari pop-ups and file downloads disabled (default case) but on enabling them it makes no difference - still no joy (downloads was "Ask" anyway).
For the Safari "Discs/download drive 0 image as SSD/DSD", it does pause for 2 seconds as though it's doing something, but there's no feedback and no file received.

For both Safari and Chrome, clicking on the "Discs/From Google Drive/Load or create disc from your Google Drive account" actually goes off to my google drive's web site, not reading the files from the "jsbeeb disc images" directory it created there and staying in jsbeeb, like your video shows for you.

I have more than 1 google account - is this likely a cause?

[mattgodbolt]

Thanks for checking. I'll dig about a bit more. The gapi missing is an indication the (async) google api library failed to load.

I also have multiple google accounts: the picker usually pops up (in the video it didn't as I had just done so prior to recording).

Is there anything in the javascript console when you download and/or can you paste the full output as it might have a clue about the google API loading too

[pjmi1]

Does this help - result of clicking on the google button:

[mattgodbolt]

Yes - a little. Can you send everything, like, from a clean open of the page. I'm suspecting the google API is failing to load earlier in the process, before the google button is even pressed

[mattgodbolt]

e.g. this is what I see in the output when I just load the page (and do nothing else):

GL Canvas set up
google-drive.js:28 Creating GAPI
6502.js:1101 Loading OS from roms/os.rom
6502.js:1089 Loading ROM from roms/BASIC.ROM
6502.js:1089 Loading ROM from roms/b/DFS-1.2.rom
google-drive.js:30 Got GAPI, creating token client
fdc.js:6 Loading disc from discs/elite.ssd
google-drive.js:39 Token client created, loading client
google-drive.js:47 Google Drive: available
google-drive.js:42 Client loaded; initialising GAPI
google-drive.js:44 GAPI initialised

[mattgodbolt]

(note to self; I use a technique from google/google-api-javascript-client#319 to load the API and maybe that's broken)

[mattgodbolt]

AH! I think I have it. ASt least the google bit!

[pjmi1]

On launching jsbeeb I get similar:

[mattgodbolt]

Perfect: thank you! I think I have a fix; I just pushed it and it will appear on the site in ~5m or so. That fixes the GDrive bit anyway (hopefully)

The "download" part is more tricky...

[pjmi1]

Well, the google drive save and load works, thanks, except the disc comes back empty when loaded from google drive.
Also, can we save the disc as double sided (drive 0 and 2 together), if these are already both valid?
Cheers

[mattgodbolt]

So save and load works...but disk changes aren't persisted? I'll poke about. sorry!

[mattgodbolt]

Agreed - should make the disc two-sided!

When I load up a disk and then make a change:

Creating GAPI
google-drive.js:30 Got GAPI, creating token client
google-drive.js:39 Token client created, loading client
google-drive.js:42 Client loaded; initialising GAPI
google-drive.js:47 Google Drive: available
main.js:943 Google Drive available = true
main.js:947 Google Drive authed= true
google-drive.js:44 GAPI initialised
google-drive.js:146 Making editable disc
main.js:958 Google Drive loading finished
utils.js:799 event noted: keyboard press break

I made the change and shortly after I get:

google-drive.js:148 Data changed...
google-drive.js:96 Found existing parent folder
google-drive.js:150 Saved ok

(all in the console)

Then reloading the page and I see that my change took place.

What do you see?