Perform config validation in its own function, rather than using `OnConfigurationChange` to check

[mickmister]

I understand we are calling OnConfigurationChange here to make sure we exit if we cannot create the channel or user. Nevertheless, I wonder if we should separate this in a different function (e.g. CreateUserAndChannel). Semantically, here there are no configuration changes. We are just trying to create the channel and the user to exit if they cannot be created.

Originally posted by @larkox in https://github.com/mattermost/mattermost-plugin-demo/timeline

Edit: GitHub's "Reference in new issue" feature seems to have created a broken link above. Here's the actual comment this ticket came from #109 (comment)

[saltperfect]

Can some one add more details to this? the link is also outdated here.

[mickmister]

@saltperfect I found the discussion this ticket was made from #109 (comment). I'm not sure what the /timeline thing is in this ticket's description.

The ask here is to:

1. Move this code into its own function CreateUserAndChannels:

mattermost-plugin-demo/server/configuration.go

Lines 211 to 225 in b04ab55

	botID, ensureBotError := p.Helpers.EnsureBot(&model.Bot{
	Username: "demoplugin",
	DisplayName: "Demo Plugin Bot",
	Description: "A bot account created by the demo plugin.",
	}, plugin.ProfileImagePath("/assets/icon.png"))
	if ensureBotError != nil {
	return errors.Wrap(ensureBotError, "failed to ensure demo bot.")
	}
	p.botID = botID
	configuration.demoChannelIDs, err = p.ensureDemoChannels(configuration)
	if err != nil {
	return errors.Wrap(err, "failed to ensure demo channels")
	}

2. Do not call this code in OnConfigurationChange

3. Remove the call to OnConfigurationChange below, and call CreateUserAndChannels instead:

mattermost-plugin-demo/server/activate_hooks.go

Line 44 in b04ab55

if err := p.OnConfigurationChange(); err != nil {

---

@saltperfect Does this make sense? Thanks for your interest in the ticket!

[saltperfect]

It does now. Thanks 😊

[adithyaakrishna]

@mickmister I would like to take this up :)