roundTo is probably wrong

[dk-teknologisk-osv]

Calling roundTo(103.35, 0.1) gives 103.30000000000001 where it should give 103.4.

Original function:

/** Round a number `n` to the nearest multiple of `increment`. */
export function roundTo(n: number, increment = 1) {
  return Math.round(n / increment) * increment;
}

This function looks to work properly:

function roundTo(n: number, increment = 1) {
  const v1 = Math.round(n / increment ) * increment 
  const v2 = Math.round(n / increment + 1e-10) * increment 
  const v3 = Math.round(n / increment - 1e-10) * increment 
  return Math.abs(v1 - v2) > increment / 10 ? v2 : v3
}

[plegner]

I'm not sure if it is worth adding this performance overhead to deal with floating-point edge cases, but we'll definitely keep it in mind for future updates.

In this example, if you want to round to a certain number of decimal places, you could instead just use the round() function which should not have this issue:

import {round} from '@mathigon/fermat`
console.log(round(103.35, 1)); // => 103.4

[dk-teknologisk-osv]

That is true, but in our case we need to use roundTo function. 0.1 increment was just an example 😉.

PS: For me it is more important that the functions that I use are correct and I can always rely on them and only after that comes speed. 👍