Forge Existing Enchantments

[math0898]

The current forge implementation does not consider enchantments already present on an item. It should consider them and upgrade any present if it matches the level of the added book.

[cybellereaper]

This can be done, but probably deserves a rewrite of the system, maybe it'd be ideal to make rpgenchants enhance the vanilla experience by having custom enchantments like lava walker that acts like frostwalker on lava etc, that's if you're clarifying vanilla enchantments with custom enchantments.

I'd say make a de-enchant system of some sort where it can transfer or give you it as a book by a random chance in an anvil.

[cybellereaper]

Item A = item you enchanted via (forge) extracting the enchant with like harden stone or something (then has a chance in the anvil) to give you the book back as the result maybe?

[cybellereaper]

But in order for this stuff to work we'd have to do the issue of pdc on the items first, and work our way through this system once again, properly making a pdc system is ideal.

[math0898]

Custom enchantments would be awesome. The current forge works as a way to add usually conflicting or too high level'd enchantments to an item. It's essentially a crafting system. It'd be cool to add in extra upgrades outside of the vanilla enchants that may increase attribute stats or have custom effects like Telekinesis from Hypixel Skyblock for example.

Only some custom enchantments would need PDC to do effects like this. The current functionality, the enhancement to consider item enchantments already applied, and even adding attributes to increase stats would not.

As for transferring enchantments or removing them; I made a separate issue #15. It's been requested for awhile. I believe the systems should be separate.