Add max number of tokens for a crowdsale

[marv-engine]

Based on feedback from MaidSafe, we should let crowdsales specify a hard limit for the number of tokens/coins that are issued during the sale. The current implementation doesn't provide a way for the issuer to cut off sales after a particular number are sold. It's up to the issuer to monitor sales and close the sale manually, but this can't be done at a predetermined number.

Transaction 51 uses (requires) a time limit, so it should have an optional limit on the number of tokens. Zero could indicate no limit.

Some special handling will be required when a participant tries to purchase more tokens than are left to be purchased (including early bird bonus and issuer's percentage). We'll need some way to return/refund the extra payment.

[dacoinminster]

Interesting idea. We'll probably want to rev the issuance model at some point, and this change would possibly make sense to include.

Curious why this issue is here rather than on the spec?

[marv-engine]

We should look at updating the issuance model sooner rather than later. There are several lessons from the MaidSafe experience that we should incorporate for the benefit of upcoming issuers and crowdsale participants.

This issue is here because features/capabilities in the spec should be tied to user-level product requirements. Starting here gives us an audit trail and provides a way to confirm that the spec and implementations meet the user requirements they're derived from.

[dacoinminster]

Yeah, I expect the priority should be:

1. TX 50
2. TX 21
3. Version 2.0 of crowdsale stuff with more options

Needs to be hashed out

On Fri, Apr 25, 2014 at 6:19 AM, Marv Schneider notifications@github.comwrote:

We should look at updating the issuance model sooner rather than later.
There are several lessons from the MaidSafe experience that we should
incorporate for the benefit of upcoming issuers and crowdsale participants.

This issue is here because features/capabilities in the spec should be
tied to user-level product requirements. Starting here gives us an audit
trail and provides a way to confirm that the spec and implementations meet
the user requirements they're derived from.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/3#issuecomment-41391241
.