Refactor nudge tasks to improve failure handling and return values

- Updated the community admin events and testimonials nudges to return None for failure messages when no emails are sent, while still including failure details in the result.
- Adjusted the user event nudge to follow the same pattern, ensuring consistent handling of empty audiences and failure reporting across all nudge tasks.

Author: abdullai-t

src/task_queue/nudges/cadmin_events_nudge.py

@@ -157,19 +157,15 @@ def send_events_nudge(task=None) -> Tuple[bool, str]:
 
         update_last_notification_dates(admins_emailed, CADMIN_NUDGE_KEY)
 
-        # If any failures occurred, report them and fail the overall task
-        if failures:
-            result = {
-                "audience": ",".join(admins_emailed),
-                "scope": "CADMIN",
-                "failures": failures,
-            }
-            return result, None
+        if len(admins_emailed)==0:
+            result = {"audience": ",".join(admins_emailed), "scope": "USER", "failures": failures}
+            return None, str(result)
 
 
         result = {
             "audience": ",".join(admins_emailed),
             "scope": "CADMIN",
+            "failures": failures,
         }
 
         return result, None

src/task_queue/nudges/cadmin_testimonial_nudge.py

@@ -232,13 +232,12 @@ def prepare_testimonials_for_community_admins(task=None):
 
 		update_last_notification_dates(emailed_list, TESTIMONIAL_NUDGE_KEY)
 
-		# If any failures occurred, report them and fail the overall task
-		if failures:
-			res = {"scope":"CADMIN","audience": ",".join(emailed_list), "failures": failures}
-			return res, None
+		if len(emailed_list)==0:
+			result = {"audience": ",".join(emailed_list), "scope": "USER", "failures": failures}
+			return None, str(result)
 
 
-		res = {"scope":"CADMIN","audience": ",".join(emailed_list)}
+		res = {"scope":"CADMIN","audience": ",".join(emailed_list), "failures": failures}
 		log.info("Successfully sent nudge to all community admins")
 		return res, None
 	except Exception as e:

src/task_queue/nudges/user_event_nudge.py

@@ -345,15 +345,12 @@ def prepare_user_events_nudge(task=None, email=None, community_id=None):
         for email_addr in audience:
             update_last_notification_dates(email_addr)
 
-        
-        # If any failures occurred, report them and fail the overall task
-        if failures:
+        if len(audience)==0:
             result = {"audience": ",".join(audience), "scope": "USER", "failures": failures}
-            return result, None
-
-
+            
+            return None, str(result)
 
-        result = {"audience": ",".join(audience), "scope": "USER"}
+        result = {"audience": ",".join(audience), "scope": "USER", "failures": failures}
 
         return result, None
     except Exception as e: