Merge relevant new tests from serialization branch

Author: masaccio

src/fractured_json/__init__.py

@@ -178,6 +178,9 @@ def list_options(self) -> dict[str, dict[str, object | str | list | bool]]:
 
     def get(self, name: str) -> int | bool | str | NativeEnum:
         """Getter for an option that calls the .NET class."""
+        if name not in self._properties:
+            msg = f"Unknown option '{name}'"
+            raise AttributeError(msg)
         prop = self._properties[name]["prop"]
         if self._properties[name]["is_enum"]:
             native_value = prop.GetValue(self._dotnet_instance)
@@ -226,7 +229,7 @@ def set(self, name: str, value: int | bool | str | NativeEnum) -> None:  # noqa:
         """Setter for an option that calls the .NET class."""
         if name not in self._properties:
             msg = f"Unknown option '{name}'"
-            raise KeyError(msg)
+            raise AttributeError(msg)
 
         prop = self._properties[name]["prop"]
         try:
@@ -254,7 +257,8 @@ def __setattr__(self, name: str, value: int | bool | str | NativeEnum) -> None:
             try:
                 self.set(name, value)
             except AttributeError:
-                object.__setattr__(self, name, value)
+                msg = f"{type(self).__name__} has no attribute '{name}'"
+                raise AttributeError(msg) from None
 
 
 class Formatter:
@@ -279,12 +283,12 @@ def options(self, value: FracturedJsonOptions) -> None:
         prop = FormatterType.GetProperty("Options")
         prop.SetValue(self._dotnet_instance, value._dotnet_instance)
 
-    def reformat(self, json_text: str) -> str:
+    def reformat(self, json_text: str, starting_depth: int = 0) -> str:
         """Reformat a JSON string and return the formatted result."""
         if not isinstance(json_text, str):
             msg = "json_text must be a str"
             raise TypeError(msg)
-        result = self._dotnet_instance.Reformat(String(json_text))
+        result = self._dotnet_instance.Reformat(String(json_text), Int32(starting_depth))
         return str(result)
 
     def minify(self, json_text: str) -> str:

tests/test_console_script.py

@@ -1,5 +1,7 @@
 import re
+from io import StringIO
 from pathlib import Path
+from shutil import copy
 
 import pytest
 
@@ -139,6 +141,28 @@ def test_output(script_runner, tmp_path):
     assert tmp_file.read_text() == '{ "bools": {"true": true, "false": false} }\n'
 
 
+def test_in_place(script_runner, tmp_path):
+    tmp_file = tmp_path / "test.json"
+    copy(Path("tests/data/test-bool.json"), tmp_file)
+    ret = script_runner.run(
+        ["fractured-json", "--in-place", tmp_file],
+    )
+    assert ret.stderr == ""
+    assert ret.success
+    assert tmp_file.read_text() == '{ "bools": {"true": true, "false": false} }\n'
+
+    timestamp = tmp_file.stat().st_mtime_ns
+
+    ret = script_runner.run(
+        ["fractured-json", "--in-place", tmp_file],
+    )
+    assert ret.stderr == ""
+    assert ret.success
+    assert tmp_file.read_text() == '{ "bools": {"true": true, "false": false} }\n'
+
+    assert timestamp == tmp_file.stat().st_mtime_ns
+
+
 def test_output_mismatched_number_of_files(script_runner):
     ret = script_runner.run(
         [
@@ -152,3 +176,21 @@ def test_output_mismatched_number_of_files(script_runner):
     )
     assert ret.stderr == "fractured-json: the numbers of input and output file names do not match\n"
     assert ret.returncode == 1
+
+
+def test_pipe_stdin(script_runner):
+    json_input_fh = StringIO(Path("tests/data/test-bool.json").read_text())
+    ret = script_runner.run(["fractured-json", "-"], stdin=json_input_fh)
+    assert ret.success
+    assert ret.stderr == ""
+    assert ret.success
+    assert ret.stdout == '{ "bools": {"true": true, "false": false} }\n'
+
+
+def test_missing_file(script_runner, tmp_path):
+    ret = script_runner.run(
+        ["fractured-json", "file-does-not-exist.json"],
+    )
+    assert not ret.success
+    assert "[Errno 2] No such file or directory: 'file-does-not-exist.json'" in ret.stderr
+    assert ret.stdout == ""

tests/test_formatter.py

@@ -73,8 +73,15 @@ def test_minify():
     assert test_output == ref_output
 
 
+def test_depth():
+    json_input = Path("tests/data/test-bool.json").read_text()
+    formatter = Formatter()
+    test_output = formatter.reformat(json_input, 2)
+    assert test_output == '        { "bools": {"true": true, "false": false} }\n'
+
+
 def test_exceptions():
-    with pytest.raises(KeyError, match="Unknown option 'non_existent_option'"):
+    with pytest.raises(AttributeError, match="Unknown option 'non_existent_option'"):
         _ = FracturedJsonOptions(non_existent_option=True)
 
     with pytest.raises(
@@ -110,6 +117,19 @@ def test_exceptions():
     with pytest.raises(TypeError, match="Must be callable"):
         formatter.string_length_func = 123  # type: ignore[assignment]
 
+    options = FracturedJsonOptions()
+    with pytest.raises(
+        AttributeError,
+        match="FracturedJsonOptions has no attribute 'invalid'",
+    ):
+        _ = options.invalid
+
+    with pytest.raises(
+        AttributeError,
+        match="FracturedJsonOptions has no attribute 'invalid'",
+    ):
+        options.invalid = 0
+
 
 def test_dll_missing(path_is_file_fails):  # noqa: ARG001
     if "fractured_json" in sys.modules:
@@ -142,3 +162,26 @@ def double_len(s: str) -> int:
     getter = formatter.string_length_func
     assert callable(getter)
     assert getter("abc") == 6
+
+
+def test_formatter_options():
+    opts = FracturedJsonOptions(
+        max_total_line_length=80,
+        indent_spaces=3,
+        comment_policy="REMOVE",
+        table_comma_placement="BEFORE_PADDING_EXCEPT_NUMBERS",
+        number_list_alignment="LEFT",
+        prefix_string="::",
+        use_tab_to_indent=False,
+    )
+
+    formatter = Formatter()
+    formatter.options = opts
+
+    got = formatter.options
+    assert got.max_total_line_length == 80
+    assert got.indent_spaces == 3
+    assert got.comment_policy.name == "REMOVE"
+
+    got.max_total_line_length = 100
+    assert got.max_total_line_length == 100

tests/test_native_enum.py

@@ -0,0 +1,10 @@
+from fractured_json import CommentPolicy, NumberListAlignment
+
+
+def test_eq_and_hash():
+    assert CommentPolicy.REMOVE != CommentPolicy.PRESERVE
+    assert NumberListAlignment.LEFT == 0
+    a = dict()
+    a[CommentPolicy.REMOVE] = "test"
+    assert list(a.keys())[0].name == "REMOVE"
+    assert list(a.keys())[0].value == 1