Graphviz notebook failure not failing in CI

[markrichardson]

This old chestnut just keeps on coming back! @HarryCampion @tschm

[markrichardson]

https://markrichardson.github.io/dummyrepo/marimushka/notebooks/notebook-extras.html

[markrichardson]

[markrichardson]

yet ... checks say all good

[markrichardson]

I understand the sense in which this might formally be a "pass" (in terms of running the notebook / completing the build), but I think we need to set up the CI tests such that they correspond to end-state success & failure from the user's perspective

[HarryCampion]

I think we need a better test for it. Can see even the Marimo export is not producing a fail so nothing to catch

https://github.com/markrichardson/dummyrepo/actions/runs/21010599907/job/60404243799

You can set the build-extras like this

https://github.com/janushendersonassetallocation/loman/blob/master/.rhiza/make.d/00-additional-deps.mk

[HarryCampion]

nothing here either https://github.com/markrichardson/dummyrepo/actions/runs/21010599910/job/60404253390

[markrichardson]

yep - I won't put the build-extras step in just yet then. we can keep it like this for now to provide a test (of the test)

[HarryCampion]

yep - I won't put the build-extras step in just yet then. we can keep it like this for now to provide a test (of the test)

good idea

[tschm]

Chestnut indeed 🤣 I can also reach out to my Marimo contacts. A Marimo export should fail if the notebook fails