Problem with newest version and translating choices

[javiert239]

First a little context:
A few years ago I transalted Chrono Clock, but due to issues with the tool at that time, I released the translation with some unfihished things.
Now with a newer version of the tool I want to fix that.

The unfinished issues were:
-Translating the images
-Issues with lines that are repeated in several places

I realize those issues could be fixed with a newer version. And in the case of the images, I saw in another repo that is possilbe to redirect the images you want to translate (I already tried and is working).

Now, I have two issues with the the newest versions:
-The version 7.7.2 and 7.7.0 are detected by my antivirus and the internet browser as malicious files.
Althought it can be a false positive, I can't release a patch with that problem since the users would complaint.
Is there some code modification that can be done to solve this?

-Whith the version 7.6.25 (not detectd as malicious), the redirect of the images and translation work just fine, but there is just one thing that doesn't translate: the choices.
I activated the debug, and I can see the translation taking place, but I not see that displayed.
But I only see one of the translation of two choices taking place in the debug (TCR level), the other choice is nowhere to be found.
If I activate the "Overwrite" option, that choice is translated, but I break another things (and the option "SafeOverwrite" doesn't do anything).
I leave the srl.ini attached as a txt,

SRL.txt

[marcussacana]

Well, about the AV detection, frankly can be anything, since SRL is a tool has a lot of advanced features, like JIT executable assembly code generation, hooking and patching other programs, i'm more surprised that old versions are not triggered by AV, I really don't trust on AV crap since I known how it works then I never really tested the SRL with some AV.
If you can tell exactly the version where your AV start to detect SRL as malicous it may hint me what I did that made the tool be flagged to you, then I can consider if is some alternative way to do the same feature of the given version or just allow special builds with the feature removed.

[javiert239]

The AV started detecting the tool as malicious from version 7.7.0. The previous version, 7.6.25, don't trigger any alert.
If you can solve this issue, maybe with the newest versions of the tool, the other issue can be fixed on it's own (about the choices not being translated).

[marcussacana]

This is literally all that changed between the 2 versions
7.6.25...7.7.0
Give me a moment, I will try revert this commit then send you a build to check if still flagged

[marcussacana]

Check this build
SRL.zip

[marcussacana]

Well still flagged by Avast it seems

AV is just like that, it may that version 7.6.25 has whitelist manually by the AV. Is possible to open a ticket to the AV support asking to analyze the false positive. To solve all issues it would be using a digital certificate to sign the executable, but it's paid, not worth to do on a open source tool.

[javiert239]

It's still better than before, my AV and the internet browser doesn't detect it as a virus.

[marcussacana]

I was able to reduce a bit more, test this one on your AV

SRL.zip

[marcussacana]

It seems the feature name that I choosed AntiIlegalChar it is triggering some AVs, as I said those crap are just dumb.
I will consider renaming the feature for next builds

[marcussacana]

Also, good job with the Chrono Clock, I love a lot that game.

[javiert239]

Thank you, I also think it's a great game and that's why I want to give it the best translation possible (here I am four years later after all haha).

All good with the AV, no alerts on my side, and seeing even less in te virustotal page is the best for the users.
And yes, I too have to deal with this problems on my actual job.

Sadly, the problem with the choices not being translated still remains.
Strange, the version I used to translated the game in the beggining doesn't have this problem. It was a very old one, from the repo "Specific-Games". Seeing the details it says version 1.0.0.

Do you have any idea of some parameter combination that could solve this?
I tried many and even all of them, but with no luck.

[marcussacana]

It may be some regression, I would need to test in the game but I can't do that right now, only on weekends I would have time to check it.

[marcussacana]

On SRL log you see SoftPal#B or SoftPal#A?

[javiert239]

No, I don't see that.

I left here the log file (with the debug and the TRC level activated), and a sample screen.

In the last lines of the log you can see how the translation is been applied to the choice, but in the game that change is not displayed.

SRL.log

[marcussacana]

On old SRL.ini that works the choice, check the result of Offset at [CMVS], check if the value matches with the Offset with the newest version, if not try change the value from the newest to be the same of the one where choice works.

[javiert239]

The old SRL.ini don't have an Offset options.

This is all that have:
[StringReloader]
InEncoding=ISO-8859-1
OutEncoding=ISO-8859-1
Wide=false
Debug=false
Delay=false
Dump=false
DumpRetail=false
DetectText=false
Log=false
LogFile=false
Unsafe=true
Rebuild=false
AntiCrash=false
FreeOnExit=false
TrimRangeMissmatch=false
AcceptableRanges=0-9A-Za-zÀ-ÃÇ-ÎÓ-ÕÚ-Ûà-ãç-îó-õú-û｡-ﾟ !?.,
MatchIgnore=
TrimChars= ,<,(,[,［,《,«,「,『,【,],］,》,»,」,』,】,),>,",～,,%K,%LC,♪,%P
BreakLine=\n
DenyChars=@,§,$,_,<,>,/,[,]
Multithread=true
WindowHook=false
Invalidate=false
CachePointer=false
NoDiagCheck=true
LiteralMask=true
LiveSettings=true
DecodeInputRemap=false

[WordWrap]
Enable=true
Monospaced=false
FontName=MS Gothic
FontSize=14.0
Bold=false
MaxWidth=6000

[MTL]
SourceLang=JA
TargetLang=EN