From ec0e5e4ba27e7098f960c59a973c0279242d4d75 Mon Sep 17 00:00:00 2001 From: Marco de Jongh Date: Tue, 13 Jan 2026 10:05:24 +1100 Subject: [PATCH 1/2] fix: Resolve AntD deprecation warnings across the codebase - Replace Space `direction` prop with `orientation` (18 occurrences in 14 files) - Replace Select `onDropdownVisibleChange` with `onOpenChange` (2 files) - Replace Alert `message` prop with `title` (12 files) - Fix useForm disconnection in auth-modal.tsx by adding `forceRender: true` to tab items and using `destroyOnHidden={false}` on Tabs These changes eliminate the following console warnings: - [antd: Space] direction is deprecated. Please use orientation instead. - [antd: Select] onDropdownVisibleChange is deprecated. Please use onOpenChange instead. - [antd: Alert] message is deprecated. Please use title instead. - Instance created by useForm is not connected to any Form element. Co-Authored-By: Claude Opus 4.5 --- .../[playlist_uuid]/playlist-climbs-list.tsx | 2 +- .../[playlist_uuid]/playlist-edit-drawer.tsx | 2 +- .../[angle]/playlists/creator-name-select.tsx | 2 +- packages/web/app/about/about-content.tsx | 4 ++-- .../web/app/auth/error/auth-error-content.tsx | 4 ++-- .../web/app/auth/login/auth-page-content.tsx | 2 +- .../verify-request/verify-request-content.tsx | 4 ++-- packages/web/app/components/auth/auth-modal.tsx | 17 ++++++++++++----- .../components/board-page/angle-selector.tsx | 2 +- .../climb-actions/actions/playlist-action.tsx | 4 ++-- .../climb-actions/actions/tick-action.tsx | 2 +- .../create-climb/create-climb-form.tsx | 2 +- .../moonboard-create-climb-form.tsx | 8 ++++---- .../web/app/components/logbook/tick-button.tsx | 2 +- .../moonboard-import/moonboard-bulk-import.tsx | 4 ++-- .../app/components/queue-control/queue-list.tsx | 2 +- .../search-drawer/basic-search-form.tsx | 2 +- .../search-drawer/setter-name-select.tsx | 2 +- .../settings/aurora-credentials-section.tsx | 4 ++-- .../setup-wizard/join-session-tab.tsx | 8 ++++---- .../web/app/settings/settings-page-content.tsx | 2 +- 21 files changed, 44 insertions(+), 37 deletions(-) diff --git a/packages/web/app/[board_name]/[layout_id]/[size_id]/[set_ids]/[angle]/playlist/[playlist_uuid]/playlist-climbs-list.tsx b/packages/web/app/[board_name]/[layout_id]/[size_id]/[set_ids]/[angle]/playlist/[playlist_uuid]/playlist-climbs-list.tsx index f4497800..2b63103f 100644 --- a/packages/web/app/[board_name]/[layout_id]/[size_id]/[set_ids]/[angle]/playlist/[playlist_uuid]/playlist-climbs-list.tsx +++ b/packages/web/app/[board_name]/[layout_id]/[size_id]/[set_ids]/[angle]/playlist/[playlist_uuid]/playlist-climbs-list.tsx @@ -219,7 +219,7 @@ export default function PlaylistClimbsList({ )} diff --git a/packages/web/app/[board_name]/[layout_id]/[size_id]/[set_ids]/[angle]/playlist/[playlist_uuid]/playlist-edit-drawer.tsx b/packages/web/app/[board_name]/[layout_id]/[size_id]/[set_ids]/[angle]/playlist/[playlist_uuid]/playlist-edit-drawer.tsx index 5cf0cb16..5c99e06a 100644 --- a/packages/web/app/[board_name]/[layout_id]/[size_id]/[set_ids]/[angle]/playlist/[playlist_uuid]/playlist-edit-drawer.tsx +++ b/packages/web/app/[board_name]/[layout_id]/[size_id]/[set_ids]/[angle]/playlist/[playlist_uuid]/playlist-edit-drawer.tsx @@ -164,7 +164,7 @@ export default function PlaylistEditDrawer({ open, playlist, onClose, onSuccess label="Visibility" valuePropName="checked" > - + - + {/* Hero Section */}
@@ -68,7 +68,7 @@ export default function AboutContent() { type="warning" showIcon icon={} - message="Single Vendor Risk" + title="Single Vendor Risk" description="Thousands of dollars worth of climbing equipment relies on software from two small companies. If that software stops working, your expensive LED system becomes unusable." /> diff --git a/packages/web/app/auth/error/auth-error-content.tsx b/packages/web/app/auth/error/auth-error-content.tsx index 22551ee3..2f81eb96 100644 --- a/packages/web/app/auth/error/auth-error-content.tsx +++ b/packages/web/app/auth/error/auth-error-content.tsx @@ -71,10 +71,10 @@ export default function AuthErrorContent() { }} > - + Authentication Error - + diff --git a/packages/web/app/auth/login/auth-page-content.tsx b/packages/web/app/auth/login/auth-page-content.tsx index 0d85c821..d39c7b03 100644 --- a/packages/web/app/auth/login/auth-page-content.tsx +++ b/packages/web/app/auth/login/auth-page-content.tsx @@ -268,7 +268,7 @@ export default function AuthPageContent() { }} > - + Sign in or create an account to continue diff --git a/packages/web/app/auth/verify-request/verify-request-content.tsx b/packages/web/app/auth/verify-request/verify-request-content.tsx index 8548c1ca..02484030 100644 --- a/packages/web/app/auth/verify-request/verify-request-content.tsx +++ b/packages/web/app/auth/verify-request/verify-request-content.tsx @@ -88,11 +88,11 @@ export default function VerifyRequestContent() { }} > - + {errorMessage ? ( <> - + ) : ( <> diff --git a/packages/web/app/components/auth/auth-modal.tsx b/packages/web/app/components/auth/auth-modal.tsx index 596159fb..0ff27176 100644 --- a/packages/web/app/components/auth/auth-modal.tsx +++ b/packages/web/app/components/auth/auth-modal.tsx @@ -115,8 +115,13 @@ export default function AuthModal({ }; const handleCancel = () => { - loginForm.resetFields(); - registerForm.resetFields(); + // Only reset the active form to avoid "useForm not connected" warning + // The inactive tab's form may not be connected to the DOM + if (activeTab === 'login') { + loginForm.resetFields(); + } else { + registerForm.resetFields(); + } onClose(); }; @@ -124,6 +129,7 @@ export default function AuthModal({ { key: 'login', label: 'Login', + forceRender: true, children: (
- - + + {title} {description} - + or diff --git a/packages/web/app/components/board-page/angle-selector.tsx b/packages/web/app/components/board-page/angle-selector.tsx index f6706a10..fb9cf376 100644 --- a/packages/web/app/components/board-page/angle-selector.tsx +++ b/packages/web/app/components/board-page/angle-selector.tsx @@ -151,7 +151,7 @@ export default function AngleSelector({ boardName, currentAngle, currentClimb }: > {currentClimb && ( diff --git a/packages/web/app/components/climb-actions/actions/playlist-action.tsx b/packages/web/app/components/climb-actions/actions/playlist-action.tsx index b2f54e7d..41a9415d 100644 --- a/packages/web/app/components/climb-actions/actions/playlist-action.tsx +++ b/packages/web/app/components/climb-actions/actions/playlist-action.tsx @@ -158,7 +158,7 @@ export function PlaylistAction({ Add to Playlist
{playlists.length === 0 && !showCreateForm ? ( - + No playlists yet