Manual iOS build instructions error out

[1ec5]

I tried following the instructions in https://github.com/mapbox/mapbox-gl-native/blob/master/README.md#manually, but I ran into some issues:

$ brew install appledoc
Error: No available formula for appledoc 
Searching formulae...
appledoc20  appledoc21  appledoc22
Searching taps...

$ make ipackage
…
* Recording library version...
mapbox-gl-native d4fcb5bb98
* Creating build files...
git submodule update --init platform/ios/vendor/SMCalloutView
deps/run_gyp gyp/ios.gyp -Dhost=ios -Iconfig/ios.gypi -Dinstall_prefix=/usr/local -Dheadless_lib=none -Dplatform_lib=ios -Dasset_lib=fs -Dhttp_lib=nsurl -Dcache_lib=sqlite --depth=. -Goutput_dir=. --generator-output=./build/ios -f xcode
* Building iOS device targets...
./scripts/ios/package.sh: line 44: JOBS: unbound variable
./scripts/ios/package.sh: line 19: wait_for: No record of process 47919
make: *** [ipackage] Error 127

/cc @incanus

[1ec5]

Per chat with @mikemorris:

It looks like $JOBS is unbound because it's not being passed to the iOS packaging scripts in the Makefile?

[mikemorris]

This was caused by dropping source ./scripts/travis_helper.sh from scripts/ios/install.sh, because that script sets $JOBS at https://github.com/mapbox/mapbox-gl-native/blob/master/scripts/travis_helper.sh#L3-L7

[incanus]

Some of the appledoc background: Homebrew/legacy-homebrew#33541

I'm working on testing my local setup not with the appledoc I have installed from source.

[incanus]

I updated our docs around appledoc in 0d89af4 to recommend people use the 2.2v963 binary install from the GitHub release page. This is because:

• Appledoc 2.1 and 2.2 prior to 963 don't render all of the things we need
• 2.2 uses garbage collection and doesn't build from Homebrew
• I have been maintaining all of our existing iOS tools with 963 installed from source
• The Homebrew 2.2 version installs a 1xxx version which doesn't render our docs right (mostly empty)
• I tested the binary install mentioned in the commit and it works great with our docs
• People installing our whole framework from source should be ok with a good chunk of deps right now as this is a complex project

The one thing I'm unsure of is how make ipackage is succeeding on Travis given that their OS X environment description makes no mention of appledoc. Travis isn't loading for me right now to inspect an older job and see how this proceeded.

[1ec5]

ref tomaz/appledoc#526

[incanus]

Fixed in master, cherry-picking over to b1 release.