From bf53471395c50256ddcb3b327bcc8d244aa1f513 Mon Sep 17 00:00:00 2001 From: Bhargav Kowshik Date: Mon, 10 Jul 2017 17:02:44 +0530 Subject: [PATCH 1/3] Update picture on README to match example along with some coolness --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 01abc99..64dd182 100644 --- a/README.md +++ b/README.md @@ -36,7 +36,7 @@ npm install ## Prediction -screen shot 2017-06-30 at 4 17 46 pm +screen shot 2017-07-10 at 4 59 03 pm ```bash From a3db5f1192952f34f9e85987516f64766761d30a Mon Sep 17 00:00:00 2001 From: Bhargav Kowshik Date: Wed, 19 Jul 2017 14:26:55 +0530 Subject: [PATCH 2/3] Fixed some linting errors --- datasets/analyze-predictions.js | 6 +++--- datasets/extract-feature.js | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/datasets/analyze-predictions.js b/datasets/analyze-predictions.js index c27145d..126b88d 100644 --- a/datasets/analyze-predictions.js +++ b/datasets/analyze-predictions.js @@ -4,7 +4,7 @@ const argv = require('minimist')(process.argv.slice(2)); const fs = require('fs'); const path = require('path'); -const OSMCHA_URL = 'https://osmcha.mapbox.com/' +const OSMCHA_URL = 'https://osmcha.mapbox.com/'; if (!argv.predictionsDir) { console.log(''); @@ -56,7 +56,7 @@ while (true) { // If changeset is already seen, skip. if (goodChangesets.has(good.changeset_id)) continue; - console.log(OSMCHA_URL + good.changeset_id + '/' + '\t' + getFeatureHash(good) + '.json'); + console.log(OSMCHA_URL + good.changeset_id + '/\t' + getFeatureHash(good) + '.json'); goodChangesets.add(good.changeset_id); } @@ -73,6 +73,6 @@ while (true) { // If changeset is already seen, skip. if (harmfulChangesets.has(harmful.changeset_id)) continue; - console.log(OSMCHA_URL + harmful.changeset_id + '/' + '\t' + getFeatureHash(harmful) + '.json'); + console.log(OSMCHA_URL + harmful.changeset_id + '/\t' + getFeatureHash(harmful) + '.json'); harmfulChangesets.add(harmful.changeset_id); } diff --git a/datasets/extract-feature.js b/datasets/extract-feature.js index 9841049..de95650 100644 --- a/datasets/extract-feature.js +++ b/datasets/extract-feature.js @@ -31,7 +31,7 @@ for (let version of versions) { let newVersion = version[0]; let oldVersion = version[1]; - if ((newVersion.properties.type == argv.featureType) && (newVersion.properties.id == argv.featureID)) { + if ((newVersion.properties.type === argv.featureType) && (newVersion.properties.id === argv.featureID)) { console.log(JSON.stringify(turf.featureCollection(version), null, 4)); process.exit(0); } From ae1b845b0898ae87664474997ace402e71738710 Mon Sep 17 00:00:00 2001 From: Bhargav Kowshik Date: Wed, 19 Jul 2017 14:31:26 +0530 Subject: [PATCH 3/3] Add contribution guidelines --- CONTRIBUTING.md | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 CONTRIBUTING.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md new file mode 100644 index 0000000..c2e9506 --- /dev/null +++ b/CONTRIBUTING.md @@ -0,0 +1,11 @@ +# Contributing to Gabbar + + +:tada: *Thank you for taking the time to contribute!* :tada: + + +## Development +```bash +# Code linting +npm run lint +```