Commit 8bd935d
committed
base-files: filogic: allow sysupgrade compatible profiles
These two profiles are suppose to be compatible with each other since
they are the same device except for the WAN port PHY [1].
They include the other device's dts compatible string in SUPPORTED_DEVICES
in order to allow flashing either image on either device but there is an
implicit constraint in the sysupgrade-TAR images's building script which
hardcode the "image makefile profile name"(DEVICE_NAME or BOARD_NAME if
defined) during the image-building process, but, later on, it is the
"board_name()"(dts compatible) what it is checked in "nand_do_platform_check"
during sysupgrading on device. That implies that only one specific dts
compatible string (the one which match the profile name) will do a
seamless sysupgrade [2].
In order to allow sysupgrade between these two profiles, each one with
its own dts compatible string, we need to relax this check.
Since we use fwtool for image metadata checks (including the
SUPPORTED_DEVICES check for a valid board_name), delegate to fwtool and
avoid "nand_do_platform_check" in this case.
*Git history reflects that using image METADATA is the prefered way to do
this check is using fwtool, so this change is aligned with that trend.
[1]: openwrt#18799 (comment)
[2]: openwrt#20566 (comment)
Fixes(only mediatek-filogic): openwrt#20966
Fixes: openwrt#20566
Signed-off-by: Mario Andrés Pérez <mapb_@outlook.com>1 parent 7b61fd3 commit 8bd935d
1 file changed
Lines changed: 5 additions & 0 deletions
Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
315 | 315 | | |
316 | 316 | | |
317 | 317 | | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
318 | 323 | | |
319 | 324 | | |
320 | 325 | | |
| |||
0 commit comments