Commit 8258f45
committed
octeon: add and require image METADATA for sysupgrades safety
Actually this platform is not implementing the fwtool's images METADATA
mechanism, indeed allowing* sysupgrades with images which are not meant for
the specific device, together with the fact that the platform checks in
this platform were relaxed because of changes of devices names convention
(migrated from legacy naming) so are not checking for the hardcoded
board_name in the sysupgrade-tar images neither.
*Actually, there are some board_name checks in this platform's sysupgrade
paths which minimize the risk of a wrongly cross-sysupgrade but still a
risk.
So, append the metadata to the common sysupgrade.tar image recipe and add
the REQUIRE_IMAGE_METADATA=1 flag in order to guarantee only the correct
images pass sysupgrade checks.
SUPPORTED_DEVICES was already set correctly for these devices which use
a custom sysinfo board_name since some devices do not have a proper device
tree source.
Remove confusing and wrongly "append-metadata" call in the inner squashfs
image recipe for the itus_shield-router case[1].
[1]: openwrt#3241 (comment)
Reference: openwrt@be29674
Signed-off-by: Mario Andrés Pérez <mapb_@outlook.com>1 parent 361c110 commit 8258f45
2 files changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
| 26 | + | |
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
42 | 41 | | |
43 | 42 | | |
44 | 43 | | |
| |||
0 commit comments