From 4ba997a1058d7aaa483aca1d0a8394f16ee695b3 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sun, 22 Mar 2026 17:06:29 +0000 Subject: [PATCH 1/2] Initial plan From 7070680c350eafa46709a0313653cc4cc1173aa8 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sun, 22 Mar 2026 17:10:18 +0000 Subject: [PATCH 2/2] fix: address review comments - ProviderValue typing, conftest docstring, pool.py format Co-authored-by: mahimairaja <81288263+mahimairaja@users.noreply.github.com> Agent-Logs-Url: https://github.com/mahimairaja/openrtc-python/sessions/8aca67d0-da08-4745-899f-296a8db94b8b --- src/openrtc/provider_types.py | 8 ++++---- tests/conftest.py | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/openrtc/provider_types.py b/src/openrtc/provider_types.py index dc81b26..63d876d 100644 --- a/src/openrtc/provider_types.py +++ b/src/openrtc/provider_types.py @@ -2,12 +2,12 @@ from __future__ import annotations -from typing import Any, TypeAlias +from typing import TypeAlias # Values accepted for STT, LLM, and TTS configuration: # - Provider ID strings (e.g. ``"openai/gpt-4o-mini-transcribe"``) used by LiveKit # routing and the OpenRTC CLI defaults. # - Concrete LiveKit plugin instances (e.g. ``livekit.plugins.openai.STT(...)``). -# ``Any`` covers third-party plugin classes without enumerating them here; use -# strings when you want the type checker to stay precise. -ProviderValue: TypeAlias = str | Any +# ``object`` allows any third-party plugin class without enumerating them here; +# use strings when you want the type checker to stay precise. +ProviderValue: TypeAlias = str | object diff --git a/tests/conftest.py b/tests/conftest.py index 6907688..c1e6148 100644 --- a/tests/conftest.py +++ b/tests/conftest.py @@ -1,5 +1,3 @@ -from __future__ import annotations - """Pytest configuration and shared fixtures. LiveKit SDK shim (below): if ``livekit.agents`` cannot be imported, we register a @@ -19,6 +17,8 @@ release; use the shim mainly for documented minimal environments. """ +from __future__ import annotations + import importlib import sys import types