NullReferenceException System.Drawing.Icon BitmapToIcon(System.Drawing.Bitmap)

[Maltavius]

Describe the bug
Error pops up when starting to scan.

Exact Steps to Reproduce
Running throuh Wine on Fedora Workstation 43
Resuming seems to work

If you have a crash dump paste it between ```

Crash dump

See attached file for more of the dump

Application: ComicRack Community Edition
Version    : 0.9.184
Assembly   : 1.0.9591.12873
OS         : Microsoft Windows NT 10.0.19043.0 64
.NET       : 4.0.30319.42000
Processors : 24
Workingset : 0 Bytes
THREADEXCEPTION
--------------------
NullReferenceException
System.Drawing.Icon BitmapToIcon(System.Drawing.Bitmap)
Object reference not set to an instance of an object
  at cYo.Common.Drawing.BitmapExtensions.BitmapToIcon (System.Drawing.Bitmap bitmap) [0x00054] in <ee6c7e575b0c48cda32bb755e2306f7c>:0 
  at cYo.Projects.ComicRack.Viewer.Win7.SetOverlayIcon (System.Drawing.Bitmap bitmap, System.String text) [0x00017] in <0093a8096bbd4b4fb71e9aa5170173c2>:0 
  at cYo.Projects.ComicRack.Viewer.MainForm.UpdateActivityTimerTick (System.Object sender, System.EventArgs e) [0x00348] in <0093a8096bbd4b4fb71e9aa5170173c2>:0 
  at System.Windows.Forms.Timer.OnTick (System.EventArgs e) [0x0000a] in <83e01aff7fe3465fbab8aeaba2991dd8>:0 
  at System.Windows.Forms.Timer+TimerNativeWindow.WndProc (System.Windows.Forms.Message& m) [0x0002c] in <83e01aff7fe3465fbab8aeaba2991dd8>:0 
  at System.Windows.Forms.NativeWindow.Callback (System.Windows.Forms.Message& m) [0x00025] in <83e01aff7fe3465fbab8aeaba2991dd8>:0 



Report generated at: 08/04/2026 09:53:39

Application ComicRack.txt

[maforget]

It seems related to the fix for #137. The fix used a hacky workaround by using Reflection.

ComicRackCE/cYo.Common/Drawing/BitmapExtensions.cs

Lines 633 to 647 in 7a0f8b3

	/// <summary>
	/// Create a Icon that calls DestroyIcon() when the Destructor is called.
	/// Unfortunatly Icon.FromHandle() initializes with the internal Icon-constructor Icon(handle, false), which sets the internal value "ownHandle" to false
	/// This way because of the false, DestroyIcon() is not called as can be seen here:
	/// https://referencesource.microsoft.com/#System.Drawing/commonui/System/Drawing/Icon.cs,f2697049dea34e7c,references
	/// To get arround this we get the constructor internal Icon(IntPtr handle, bool takeOwnership) from Icon through reflection and initialize that way
	/// </summary>
	public static Icon BitmapToIcon(this Bitmap bitmap)
	{
	Type[] cargt = new[] { typeof(IntPtr), typeof(bool) };
	ConstructorInfo ci = typeof(Icon).GetConstructor(BindingFlags.NonPublic | BindingFlags.Instance, null, cargt, null);
	object[] cargs = new[] { (object)bitmap.GetHicon(), true };
	Icon icon = (Icon)ci.Invoke(cargs);
	return icon;
	}

It might be related to the fact you run via Wine. But there might be other factors because that would mean that you would get that error every time you update/convert, etc. I am sure that if every users using Wine got an exception with pretty much every actions I would have seen some feedback related to that.

Anyway, I've fixed it by calling the DestroyIcon directly instead and catching any exception so in the case that these calls aren't properly implemented in Wine, it will just not throw an exception.

Right now it's only in the dev branch. fix commit: adfd90d