Broken with Knockout 2.1.0

[ZiadJ]

I tried the dropdown control with the latest version of Knockout it did not seem to like it. Thats a pity because that's about the only UI plugin I know that works with Knockout and looks fantastic.

[farina]

Ya, I really like the structure behind this project...but it looks like it's dead :(. I might try to fork it and go off with my own set.

[bsommardahl]

What would be involved in bringing this project back to life? My team might be interested in taking it on, depending on the level of effort to get it compatible with ko 2.1.0.

[madcapnmckay]

Hi All,

I've been meaning to get back to this project and complete a rewrite and get everything working with 2.1 but have been super busy with new job etc.

I actually more or less completed a rewritten version of the tabs component which I was using as a starter for the other components. I'll try and devote most of this weekend to it and see what I can get done.

I'll aim to get the new version out in the next two weekends.

The new version includes

• A string based template source that allows overriding the templates (wanted this for a long time).
• Much cleaner code with less configuration
• UMD pattern similar to KO itself so it should work with AMD, CommonJS etc

That being said. I would also love some help maintaining the project in the future so I'd be happy to add anyone that would like to contribute.

Thanks,

Ian

[farina]

I'm kind of in the same boat with the job thing, but I'd love to help out. I'll see what I can do to get involved. It's a great project with some really interesting control concepts.

On Aug 8, 2012, at 10:54 AM, Ian Mckay notifications@github.com wrote:

Hi All,

I've been meaning to get back to this project and complete a rewrite and get everything working with 2.1 but have been super busy with new job etc.

I actually more or less completed a rewritten version of the tabs component which I was using as a starter for the other components. I'll try and devote most of this weekend to it and see what I can get done.

I'll aim to get the new version out in the next two weekends.

The new version includes

A string based template source that allows overriding the templates (wanted this for a long time).
Much cleaner code with less configuration
UMD pattern similar to KO itself so it should work with AMD, CommonJS etc
That being said. I would also love some help maintaining the project in the future so I'd be happy to add anyone that would like to contribute.

Thanks,

Ian

—
Reply to this email directly or view it on GitHub.

[bsommardahl]

My team might be interested in helping out. Our company builds knockout
apps on a daily basis and we see a lot of potential in your lib. If I could
pair program with you for a couple hours on Saturday, I could learn your
and decide if we can join in. thoughts?
On Aug 8, 2012 11:54 AM, "Ian Mckay" notifications@github.com wrote:

Hi All,

I've been meaning to get back to this project and complete a rewrite and
get everything working with 2.1 but have been super busy with new job etc.

I actually more or less completed a rewritten version of the tabs
component which I was using as a starter for the other components. I'll try
and devote most of this weekend to it and see what I can get done.

I'll aim to get the new version out in the next two weekends.

The new version includes

• A string based template source that allows overriding the templates
  (wanted this for a long time).
• Much cleaner code with less configuration
• UMD pattern similar to KO itself so it should work with AMD,
  CommonJS etc

That being said. I would also love some help maintaining the project in
the future so I'd be happy to add anyone that would like to contribute.

Thanks,

Ian

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/6#issuecomment-7591628.

[farina]

I'm not even sure how these open source projects work :P. I may not be able
to pair program this weekend, but I am interested in helping if at all
possible.

I've got a combobox control that I've been working on at the office which
might fit right into the KOUI offerings.

Keep me in the loop and I'll see what I can do.

FYI, I'm in Phoenix, AZ (which has it's own timezone essentially). Also, I
run a small Mumble server that's able to host a few people for a private
voice chat if needed.

I'm also getting pretty experienced with NuGet packages should we decide to
package this up into NuGet. I do a lot of UI design and I have all of the
graphic design tools we could need.

Farina

On Wed, Aug 8, 2012 at 12:31 PM, Byron Sommardahl
notifications@github.comwrote:

My team might be interested in helping out. Our company builds knockout
apps on a daily basis and we see a lot of potential in your lib. If I
could
pair program with you for a couple hours on Saturday, I could learn your
and decide if we can join in. thoughts?
On Aug 8, 2012 11:54 AM, "Ian Mckay" notifications@github.com wrote:

Hi All,

I've been meaning to get back to this project and complete a rewrite and
get everything working with 2.1 but have been super busy with new job
etc.

I actually more or less completed a rewritten version of the tabs
component which I was using as a starter for the other components. I'll
try
and devote most of this weekend to it and see what I can get done.

I'll aim to get the new version out in the next two weekends.

The new version includes

• A string based template source that allows overriding the templates
  (wanted this for a long time).
• Much cleaner code with less configuration
• UMD pattern similar to KO itself so it should work with AMD,
  CommonJS etc

That being said. I would also love some help maintaining the project in
the future so I'd be happy to add anyone that would like to contribute.

Thanks,

Ian

—
Reply to this email directly or view it on GitHub<
https://github.com/madcapnmckay/Knockout-UI/issues/6#issuecomment-7591628>.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/6#issuecomment-7594658.

[madcapnmckay]

@bsommardahl - I'd love to get your input. I'd prefer to do it a week this Saturday, just because I can guarantee my schedule this weekend and I should also have reworked a number of the components by then. Other than the obvious 2.1 compatibility were there any other features, issues you had experienced?

I've been putting off, incorrectly, minor maintenance because of my desire to rewrite the code. I've now become a 100% js engineer for the last 12 months so I know I can improve what was a decent but not spectacular code base. Where necessary I'm aiming to add jasmine tests, proper modularization and full jshint passing code.

I was thinking after I've pushed the new version I can add you all as contributors so you can accept pull requests. Having not collaborated on github I'm not sure what the best way to expose my dev branch to you guys earlier, any ideas? If I can do that you can get hold and critic the code before the big push.

This will be a breaking change so the old code will be grandfathered into a sub directory. I'm aiming to eliminate the legacy jquery template lib and as much of jqueryui as possible. I'd also like to touch optimize the controls but I think that will wait till after next push.

[bsommardahl]

Any chance you can push your progress to github as you are working on it?
It would be good to get a chance to try things out as you're developing
them. I also ask because I have an immediate need for the tree piece that
can't really wait two weeks. I'll either take advantage of your
already-done-code or I'll have to roll my own.

On Wed, Aug 8, 2012 at 7:22 PM, Ian Mckay notifications@github.com wrote:

@bsommardahl https://github.com/bsommardahl - I'd love to get your
input. I'd prefer to do it a week this Saturday, just because I can
guarantee my schedule this weekend and I should also have reworked a number
of the components by then. Other than the obvious 2.1 compatibility were
there any other features, issues you had experienced?

I've been putting off, incorrectly, minor maintenance because of my desire
to rewrite the code. I've now become a 100% js engineer for the last 12
months so I know I can improve what was a decent but not spectacular code
base. Where necessary I'm aiming to add jasmine tests, proper
modularization and full jshint passing code.

I was thinking after I've pushed the new version I can add you all as
contributors so you can accept pull requests. Having not collaborated on
github I'm not sure what the best way to expose my dev branch to you guys
earlier, any ideas? If I can do that you can get hold and critic the code
before the big push.

This will be a breaking change so the old code will be grandfathered into
a sub directory. I'm aiming to eliminate the legacy jquery template lib and
as much of jqueryui as possible. I'd also like to touch optimize the
controls but I think that will wait till after next push.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/6#issuecomment-7602862.

[madcapnmckay]

I would like to avoid pushing incomplete versions especially since its would involve reorganizing and breaking existing components.

I should be able to fix up the tree to work with 2.1. Shouldn't be too much wrong with it. What errors are you getting?

Do you know of any best practice for collaborating on github for major rewrites? Locally I can have a dev branch etc. Would it make sense to fork my own repo as V2. Work on that then merge back into the original and delete the fork?

[bsommardahl]

I would definitely check in your branch so that the branch is visible on
github. Since it's a branch, it doesn't matter if it is unfinished.

I forget the errors we were getting. Part of them had to do with
jquery.temp.

On 08/08/2012, at 20:10, Ian Mckay notifications@github.com wrote:

I would like to avoid pushing incomplete versions especially since its
would involve reorganizing and breaking existing components.

I should be able to fix up the tree to work with 2.1. Shouldn't be too much
wrong with it. What errors are you getting?

Do you know of any best practice for collaborating on github for major
rewrites? Locally I can have a dev branch etc. Would it make sense to fork
my own repo as V2. Work on that then merge back into the original and
delete the fork?

—
Reply to this email directly or view it on
GitHubhttps://github.com//issues/6#issuecomment-7603485.

[madcapnmckay]

OK great. I'll take a look tonight. If I recall KO 2.1 requires a certain
version of jquery.tmpl. Can you make sure it's not simply that the library
is using an older version of the tmpl library.

On Thu, Aug 9, 2012 at 3:28 PM, Byron Sommardahl
notifications@github.comwrote:

I would definitely check in your branch so that the branch is visible on
github. Since it's a branch, it doesn't matter if it is unfinished.

I forget the errors we were getting. Part of them had to do with
jquery.temp.

On 08/08/2012, at 20:10, Ian Mckay notifications@github.com wrote:

I would like to avoid pushing incomplete versions especially since its
would involve reorganizing and breaking existing components.

I should be able to fix up the tree to work with 2.1. Shouldn't be too
much
wrong with it. What errors are you getting?

Do you know of any best practice for collaborating on github for major
rewrites? Locally I can have a dev branch etc. Would it make sense to fork
my own repo as V2. Work on that then merge back into the original and
delete the fork?

—
Reply to this email directly or view it on
GitHub<
https://github.com/madcapnmckay/Knockout-UI/issues/6#issuecomment-7603485>.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/6#issuecomment-7628994.

[farina]

Are you still planning to use jQuery tmpl for KOUI? I'd just assume pull it
out and use KO's native engine. I haven't had any issue using that markup
with my applications.

Farina

On Thu, Aug 9, 2012 at 3:35 PM, Ian Mckay notifications@github.com wrote:

OK great. I'll take a look tonight. If I recall KO 2.1 requires a certain
version of jquery.tmpl. Can you make sure it's not simply that the library
is using an older version of the tmpl library.

On Thu, Aug 9, 2012 at 3:28 PM, Byron Sommardahl
notifications@github.comwrote:

I would definitely check in your branch so that the branch is visible on
github. Since it's a branch, it doesn't matter if it is unfinished.

I forget the errors we were getting. Part of them had to do with
jquery.temp.

On 08/08/2012, at 20:10, Ian Mckay notifications@github.com wrote:

I would like to avoid pushing incomplete versions especially since its
would involve reorganizing and breaking existing components.

I should be able to fix up the tree to work with 2.1. Shouldn't be too
much
wrong with it. What errors are you getting?

Do you know of any best practice for collaborating on github for major
rewrites? Locally I can have a dev branch etc. Would it make sense to
fork
my own repo as V2. Work on that then merge back into the original and
delete the fork?

—
Reply to this email directly or view it on
GitHub<

https://github.com/madcapnmckay/Knockout-UI/issues/6#issuecomment-7603485>.

—
Reply to this email directly or view it on GitHub<
https://github.com/madcapnmckay/Knockout-UI/issues/6#issuecomment-7628994>.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/6#issuecomment-7629155.

[madcapnmckay]

I'm definitely planning on removing it in the coming version. Byron needs
to get the tree working quickly prior to the next version.

On Thu, Aug 9, 2012 at 4:29 PM, Mark Farina, Jr.
notifications@github.comwrote:

Are you still planning to use jQuery tmpl for KOUI? I'd just assume pull
it
out and use KO's native engine. I haven't had any issue using that markup
with my applications.

Farina

On Thu, Aug 9, 2012 at 3:35 PM, Ian Mckay notifications@github.com
wrote:

OK great. I'll take a look tonight. If I recall KO 2.1 requires a
certain
version of jquery.tmpl. Can you make sure it's not simply that the
library
is using an older version of the tmpl library.

On Thu, Aug 9, 2012 at 3:28 PM, Byron Sommardahl
notifications@github.comwrote:

I would definitely check in your branch so that the branch is visible
on
github. Since it's a branch, it doesn't matter if it is unfinished.

I forget the errors we were getting. Part of them had to do with
jquery.temp.

On 08/08/2012, at 20:10, Ian Mckay notifications@github.com wrote:

I would like to avoid pushing incomplete versions especially since its
would involve reorganizing and breaking existing components.

I should be able to fix up the tree to work with 2.1. Shouldn't be too
much
wrong with it. What errors are you getting?

Do you know of any best practice for collaborating on github for major
rewrites? Locally I can have a dev branch etc. Would it make sense to
fork
my own repo as V2. Work on that then merge back into the original and
delete the fork?

—
Reply to this email directly or view it on
GitHub<

https://github.com/madcapnmckay/Knockout-UI/issues/6#issuecomment-7603485>.

—
Reply to this email directly or view it on GitHub<

https://github.com/madcapnmckay/Knockout-UI/issues/6#issuecomment-7628994>.

—
Reply to this email directly or view it on GitHub<
https://github.com/madcapnmckay/Knockout-UI/issues/6#issuecomment-7629155>.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/6#issuecomment-7630174.

[bsommardahl]

We use KO's native templates.

On Thu, Aug 9, 2012 at 5:29 PM, Mark Farina, Jr.
notifications@github.comwrote:

Are you still planning to use jQuery tmpl for KOUI? I'd just assume pull
it
out and use KO's native engine. I haven't had any issue using that markup
with my applications.

Farina

On Thu, Aug 9, 2012 at 3:35 PM, Ian Mckay notifications@github.com
wrote:

OK great. I'll take a look tonight. If I recall KO 2.1 requires a
certain
version of jquery.tmpl. Can you make sure it's not simply that the
library
is using an older version of the tmpl library.

On Thu, Aug 9, 2012 at 3:28 PM, Byron Sommardahl
notifications@github.comwrote:

I would definitely check in your branch so that the branch is visible
on
github. Since it's a branch, it doesn't matter if it is unfinished.

I forget the errors we were getting. Part of them had to do with
jquery.temp.

On 08/08/2012, at 20:10, Ian Mckay notifications@github.com wrote:

I would like to avoid pushing incomplete versions especially since its
would involve reorganizing and breaking existing components.

I should be able to fix up the tree to work with 2.1. Shouldn't be too
much
wrong with it. What errors are you getting?

Do you know of any best practice for collaborating on github for major
rewrites? Locally I can have a dev branch etc. Would it make sense to
fork
my own repo as V2. Work on that then merge back into the original and
delete the fork?

—
Reply to this email directly or view it on
GitHub<

https://github.com/madcapnmckay/Knockout-UI/issues/6#issuecomment-7603485>.

—
Reply to this email directly or view it on GitHub<

https://github.com/madcapnmckay/Knockout-UI/issues/6#issuecomment-7628994>.

—
Reply to this email directly or view it on GitHub<
https://github.com/madcapnmckay/Knockout-UI/issues/6#issuecomment-7629155>.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/6#issuecomment-7630174.

[madcapnmckay]

That's the issue i'm afraid. The current tree won't work without jquery tmpl, it was written almost a year before native templates came out.

I got a prototype rewritten tree completed this weekend. The tree if by far the most complicated component so the others should follow along nicely. It's currently 50% of the size of the original :) Drag and drop still to redo.