LaunchDaemon plist bug: io.macadmins.Outset.on-demand-privileged.plist (Version 4.2.0.21973)

[mbrotz]

Describe the bug
The launch daemon plist Outset.app/Contents/Library/LaunchDaemons/io.macadmins.Outset.on-demand-privileged.plist is still using an array for the program key. This is incorrect. The array should be replaced with a simple string.

Current (incorrect) state of the plist file:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
    <key>AssociatedBundleIdentifiers</key>
    <string>io.macadmins.Outset</string>
    <key>KeepAlive</key>
    <dict>
        <key>PathState</key>
        <dict>
            <key>/private/tmp/.io.macadmins.outset.ondemand-privileged.launchd</key>
            <true/>
        </dict>
    </dict>
    <key>Label</key>
    <string>io.macadmins.Outset.on-demand-privileged</string>
    <key>OnDemand</key>
    <true/>
    <key>Program</key>
    <array>
        <string>/usr/local/outset/Outset.app/Contents/MacOS/Outset</string>
    </array>
    <key>ProgramArguments</key>
    <array>
        <string>/usr/local/outset/Outset.app/Contents/MacOS/Outset</string>
        <string>--on-demand-privileged</string>
    </array>
</dict>
</plist>

Fixed plist file:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
    <key>AssociatedBundleIdentifiers</key>
    <string>io.macadmins.Outset</string>
    <key>KeepAlive</key>
    <dict>
        <key>PathState</key>
        <dict>
            <key>/private/tmp/.io.macadmins.outset.ondemand-privileged.launchd</key>
            <true/>
        </dict>
    </dict>
    <key>Label</key>
    <string>io.macadmins.Outset.on-demand-privileged</string>
    <key>OnDemand</key>
    <true/>
    <key>Program</key>
    <string>/usr/local/outset/Outset.app/Contents/MacOS/Outset</string>
    <key>ProgramArguments</key>
    <array>
        <string>/usr/local/outset/Outset.app/Contents/MacOS/Outset</string>
        <string>--on-demand-privileged</string>
    </array>
</dict>
</plist>

Additional context
Outset version: 4.2.0.21973

[bartreardon]

no it's not

<key>Program</key>
<string>/usr/local/outset/Outset.app/Contents/MacOS/Outset</string>

in https://github.com/macadmins/outset/blob/main/Package/Library/LaunchDaemons/io.macadmins.Outset.on-demand-privileged.plist

Are you looking at the payload in the package or on your local device? Is the payload incorrect on a fresh install?

[mbrotz]

I have downloaded the latest package from here: Outset-4.2.0.21973.pkg

This package installs the app to /usr/local/outset/Outset.app, as expected. The app bundle contains the faulty launch daemon.

The postinstall script of the .pkg installer copys the faulty launch daemon to /Library/LaunchDaemons.

See screenshot: