CMake error at building _deps

[NahuFigueroa97]

Hi! m2osw! great work! i try attach your library in my project:

# ###################################################################################################
# Dependencies
# ###################################################################################################
CPMAddPackage(
    NAME tld-cpp
    GITHUB_REPOSITORY m2osw/libtld
    GIT_TAG 0555304f3297bdf790223c956c2f67fb3e26bae3 # Latest master commit from 10/10/2023
    VERSION 2.0.5
)

# ###################################################################################################
# Test
# ###################################################################################################
if(ENGINE_BUILD_TEST)

set(TEST_SRC_DIR ${CMAKE_CURRENT_LIST_DIR}/test/src)
set(UNIT_SRC_DIR ${TEST_SRC_DIR}/unit)

add_executable(tld_utest
    ${UNIT_SRC_DIR}/poc_test.cpp
)
target_link_libraries(tld_utest PRIVATE tld-cpp gtest_main)
gtest_discover_tests(tld_utest)

endif(ENGINE_BUILD_TEST)

but i get this error:

CMake Error at build/_deps/tld-cpp-src/CMakeLists.txt:38 (find_package):By not providing "FindSnapCMakeModules.cmake" in CMAKE_MODULE_PATH this
project has asked CMake to find a package configuration file provided by
"SnapCMakeModules", but CMake did not find one.

Could not find a package configuration file provided by "SnapCMakeModules"
with any of the following names:

  SnapCMakeModulesConfig.cmake
  snapcmakemodules-config.cmake

Add the installation prefix of "SnapCMakeModules" to CMAKE_PREFIX_PATH or
set "SnapCMakeModules_DIR" to a directory containing one of the above
files.  If "SnapCMakeModules" provides a separate development package or
SDK, be sure it has been installed.

[NahuFigueroa97]

I modify my cmakelist

# ###################################################################################################
# Dependencies
# ###################################################################################################
CPMAddPackage(
    NAME SnapCMakeModules
    GITHUB_REPOSITORY m2osw/snapcmakemodules
    GIT_TAG f7bff08814b83c7d25a2523170b7dead0a159104 # Latest master commit from 31/11/2023
    VERSION 1.0.45.0
)

CPMAddPackage(
    NAME tld-cpp
    GITHUB_REPOSITORY m2osw/libtld
    GIT_TAG 0555304f3297bdf790223c956c2f67fb3e26bae3 # Latest master commit from 10/10/2023
    VERSION 2.0.5
)

# ###################################################################################################
# Test
# ###################################################################################################
if(ENGINE_BUILD_TEST)

set(TEST_SRC_DIR ${CMAKE_CURRENT_LIST_DIR}/test/src)
set(UNIT_SRC_DIR ${TEST_SRC_DIR}/unit)

add_executable(tld_utest
    ${UNIT_SRC_DIR}/poc_test.cpp
)
target_link_libraries(tld_utest PRIVATE SnapCMakeModules tld-cpp gtest_main)
gtest_discover_tests(tld_utest)

endif(ENGINE_BUILD_TEST)

but now i get this error:

CMake Error at build/_deps/tld-cpp-src/CMakeLists.txt:41 (SnapGetVersion):
  Unknown CMake command "SnapGetVersion

[AlexisWilke]

The library has a dependency cmakemodules.

You can either just set the version manually, try to use the cmakemodules, or create your own CMakeLists.txt (possibly the easiest long term, although you need to get some data file generated, so it's a bit advance... I had a template before, but decided to stop maintaining it at the moment).

If you're under Ubuntu, you could also look at using the package on the PPA.

[AlexisWilke]

The version variables are set like this in the cmake module:

set( ${PACKAGE_NAME}_VERSION_MAJOR ${major_version} PARENT_SCOPE )
set( ${PACKAGE_NAME}_VERSION_MINOR ${minor_version} PARENT_SCOPE )
set( ${PACKAGE_NAME}_VERSION_PATCH ${patch_version} PARENT_SCOPE )
set( ${PACKAGE_NAME}_VERSION_BUILD ${build_version} PARENT_SCOPE )

So you could do that manually with:

set( LIBTLD_VERSION_MAJOR 2 )
set( LIBTLD_VERSION_MINOR 0 )
set( LIBTLD_VERSION_PATCH 13 )
set( LIBTLD_VERSION_BUILD 1 )

If you want to stay in sync with our version, then only increment the BUILD version. Once I have an update, you can then update the other variables and reset the BUILD to 0 or 1.