Registering aliases?

[adamtomi]

I was wondering if it's possible to register aliases to certain commands using the commodore file format. Right now I have something like this:

InputStream is = //...
LiteralCommandNode<?> commandNode = CommodoreFileFormat.parse(is);
CommandNode hologramCmd = commandNode.getChild("hologram");
LiteralCommandNode child = LiteralArgumentBuilder.literal("holo")
               .redirect(hologramCmd)
               .build();

commandNode.addChild(child);
commodore.register(command, commandNode);

which is obviously not that great since I'd have to write something like shown above for all aliases. Is there a better solution for this?

[lucko]

Using Commodore#register(Command, LiteralCommandNode) will automatically register the data for all aliases of the command.

The code for that is here:

commodore/src/main/java/me/lucko/commodore/CommodoreImpl.java

Lines 166 to 171 in 1c1b628

	for (String alias : Commodore.getAliases(command)) {
	if (node.getLiteral().equals(alias)) {
	register(node);
	} else {
	register(renameLiteralNode(node, alias));
	}

commodore/src/main/java/me/lucko/commodore/CommodoreImpl.java

Lines 201 to 207 in 1c1b628

	private static <S> LiteralCommandNode<S> renameLiteralNode(LiteralCommandNode<S> node, String newLiteral) {
	LiteralCommandNode<S> clone = new LiteralCommandNode<>(newLiteral, node.getCommand(), node.getRequirement(), node.getRedirect(), node.getRedirectModifier(), node.isFork());
	for (CommandNode<S> child : node.getChildren()) {
	clone.addChild(child);
	}
	return clone;
	}

So if you're using that, there should be no more effort required on your part. :)

[adamtomi]

Yeah, all the commands using Commodore#register. However, in my case I only have 1 root command, and some subcommands. What I'm trying to achieve is to have /rootcommand subcommand <some args> and /rootcommand sub <some args> where subcommand and sub are aliases, and the two would do the same. :C

[marcbal]

I think the suggestion here is to add the ability to define command redirection in the commodore file format.

A suggestion for the commodore file format including a redirection could look like this:

your_command {
  hologram {
    // some args
  }
  holo redirect your_command hologram;
}

[adamtomi]

That'd be cool!