[2/6] Fix transposition table with proper bounds#32
Open
luccabb wants to merge 2 commits intofeature/psqt-evaluation-performancefrom
Open
[2/6] Fix transposition table with proper bounds#32luccabb wants to merge 2 commits intofeature/psqt-evaluation-performancefrom
luccabb wants to merge 2 commits intofeature/psqt-evaluation-performancefrom
Conversation
bb2ac9f to
f833c45
Compare
bca3f3e to
d7df55a
Compare
f833c45 to
7a14812
Compare
d7df55a to
e21928a
Compare
4f7fad5 to
1c7b8d9
Compare
🔬 Stockfish Benchmark Resultsvs Stockfish Skill Level 3
Non-checkmate endings:
vs Stockfish Skill Level 4
Non-checkmate endings:
vs Stockfish Skill Level 5
Non-checkmate endings:
Configuration
|
Implements correct transposition table behavior with bound types: **Transposition Table Changes:** - Add `Bound` enum: EXACT, LOWER_BOUND, UPPER_BOUND - Use Zobrist hash as cache key (fast integer vs slow FEN string) - Store bound type and depth with each cache entry - Only use cached scores when depth is sufficient - Properly handle bound types in lookups: - EXACT: use score directly - LOWER_BOUND: use if score >= beta (fail high) - UPPER_BOUND: use if score <= alpha (fail low) **Null Move Pruning Fix:** - Added missing `null_move` parameter check (was always trying null move) **Parallel Engine Updates:** - Update lazy_smp, l1p, l2p to use new zobrist hash cache key - Add context managers for Pool/Manager (proper resource cleanup) - Fix score negation in l1p (opponent perspective -> our perspective) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
fbfac44 to
6912b81
Compare
42e6fc1 to
6c5f8af
Compare
Owner
Author
|
/run-nps-benchmark |
⚡ NPS Benchmark Results
Per-position breakdown |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Boundenum (EXACT, LOWER_BOUND, UPPER_BOUND) for correct TT behaviornull_moveparameter check)Details
The transposition table now correctly stores and uses bound information:
This prevents incorrect cutoffs and score usage that can cause search instability.
Parallel Engine Updates
All parallel engines (lazy_smp, l1p, l2p) updated to:
Test plan
🤖 Generated with Claude Code