Incorrect usage of std::condition_variable

[lte678]

In Terminal::prompt_list_choice, we use std::condition_variables, but without a predicate. This can cause a deadlock or spurious wake-ups.

[lte678]

A reusable SyncBarrier class wrapping up the condition_variable has been added.

TODO: Migrate