Skip to content
This repository was archived by the owner on Apr 18, 2021. It is now read-only.
This repository was archived by the owner on Apr 18, 2021. It is now read-only.

httpcache makes two requests #29

@hauva69

Description

@hauva69

While using httpcache in an environment where we used a ReverseProxy implementation which supports several upstream hosts I noticed that the cache makes two requests to the upstream when cache has expired.

Fixing outreq in pull request Use outreq helped me, but two requests are still problematic.

  • With multiple upstreams validation can succeed, but the second request may fail.
  • Two requests, validation not being HEAD, makes it impossible to implement round robin with simple upstreams[n]%len(upstreams)

Also, we think that it is a bit strange that the code uses only differences in the headers to check whether the cache should be updated. If we respond with exactly the same headers, the cache does not seem to get updated at all.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions