fix: lint issues

logotip4ik · logotip4ik · commit ecf41eb0d8d2 · 2026-03-14T12:27:41.000+02:00
diff --git a/app/components/Toasts/Toasts.vue b/app/components/Toasts/Toasts.vue
@@ -4,7 +4,7 @@ const toasts = useToasts();
 const toasterComp = useTemplateRef('toasterComp');
 
 const sortedToasts = computed(() =>
-  toasts.value.slice().sort((a, b) => a.priority - b.priority),
+  toasts.value.toSorted((a, b) => a.priority - b.priority),
 );
 
 let toasterElClientRect: DOMRect | undefined;
diff --git a/app/components/With/ListTransitionGroup.ts b/app/components/With/ListTransitionGroup.ts
@@ -45,7 +45,7 @@ function handleArrowsPress(event: KeyboardEvent) {
     return;
   }
 
-  const currentIdx = Array.from(listElement.children)
+  const currentIdx = [...listElement.children]
     .findIndex((node) =>
     // event.target will be anchor tag, but it is wrapped in li, which is list element child
       node === (event.target as HTMLElement).parentElement,
diff --git a/app/components/Workspace/Contents/List/ContentsList.vue b/app/components/Workspace/Contents/List/ContentsList.vue
@@ -77,7 +77,7 @@ const folderContents = computed(() => {
   const notes = folder.value.notes || [];
   const subfolders = folder.value.subfolders || [];
 
-  return notes.concat(subfolders) as Array<FolderMinimal | NoteMinimal>;
+  return [...notes, ...subfolders] as Array<FolderMinimal | NoteMinimal>;
 });
 
 function showMenu(target: HTMLElement, item: FolderMinimal | NoteMinimal) {
diff --git a/app/components/Workspace/Shortcuts/Shortcuts.vue b/app/components/Workspace/Shortcuts/Shortcuts.vue
@@ -38,8 +38,8 @@ const commandsDescriptions: Record<SearchActionValues, string> = {
   [SearchAction.RefreshNote]: 'Reload only not contents',
   [SearchAction.RefreshFolder]: 'Reload only folder contents',
 };
-const commandsShortcuts = Array.from(commandActionsMin.values())
-  .map(({ key, name }) => ({ keys: name, desc: commandsDescriptions[key] }))
+const commandsShortcuts = Array
+  .from(commandActionsMin.values(), ({ key, name }) => ({ keys: name, desc: commandsDescriptions[key] }))
   .sort(sortByKeysLength);
 
 const replacementsDescriptions: Record<Replacement, string> = {
diff --git a/app/components/Workspace/Sidebar/Sidebar.vue b/app/components/Workspace/Sidebar/Sidebar.vue
@@ -20,7 +20,7 @@ function updateFocusableElements() {
     return;
   }
 
-  const elements = Array.from(sidebar.value.querySelectorAll<FocusableElement>('a,button,select'));
+  const elements = [...sidebar.value.querySelectorAll<FocusableElement>('a,button,select')];
 
   focusableElements.value = elements;
 }
diff --git a/app/composables/toaster.ts b/app/composables/toaster.ts
@@ -16,7 +16,7 @@ function addToQueue(message: ToastInstance['message'], options?: ToastUserOption
 
   const addToastToQueue = () => {
     timeout.value = undefined;
-    toasts.value = toasts.value.concat(toast);
+    toasts.value = [...toasts.value, toast];
   };
 
   if (options?.delay) {
diff --git a/app/composables/use-focus-trap.ts b/app/composables/use-focus-trap.ts
@@ -38,9 +38,7 @@ export function useFocusTrap(
   function getFocusableEls(el: HTMLElement) {
     if (scheduled) {
       scheduled = false;
-      cachedEls = Array.from(
-        el.querySelectorAll(TABBABLE_ELs) as NodeListOf<HTMLElement>,
-      ).filter((el) => !isElementHidden(el));
+      cachedEls = [...el.querySelectorAll(TABBABLE_ELs) as NodeListOf<HTMLElement>].filter((el) => !isElementHidden(el));
     }
 
     return cachedEls;
diff --git a/app/utils/fuzzy-match.ts b/app/utils/fuzzy-match.ts
@@ -98,7 +98,7 @@ if (import.meta.vitest) {
       ];
 
       const input = 'm';
-      const shuffeledList = expectedList.slice().sort(() => Math.random() - Math.random());
+      const shuffeledList = expectedList.toSorted(() => Math.random() - Math.random());
 
       expect(
         shuffeledList.sort((a, b) => fuzzyMatch(input, b) - fuzzyMatch(input, a)),
@@ -115,7 +115,7 @@ if (import.meta.vitest) {
       ];
 
       const input = 'main';
-      const shuffeledList = expectedList.slice().sort(() => Math.random() - Math.random());
+      const shuffeledList = expectedList.toSorted(() => Math.random() - Math.random());
 
       expect(
         shuffeledList.sort((a, b) => fuzzyMatch(input, b) - fuzzyMatch(input, a))[0],
@@ -131,7 +131,7 @@ if (import.meta.vitest) {
         'must watch',
         'future',
         'some testing note',
-      ].slice().sort(() => Math.random() - Math.random());
+      ].toSorted(() => Math.random() - Math.random());
 
       expect(
         shuffeledList.sort((a, b) => fuzzyMatch(input, b) - fuzzyMatch(input, a))[0],
@@ -150,7 +150,7 @@ if (import.meta.vitest) {
         'new',
         'chore',
         'some testing note',
-      ].slice().sort(() => Math.random() - Math.random());
+      ].toSorted(() => Math.random() - Math.random());
 
       const input = 'sh';
       expect(
diff --git a/app/utils/tiptap/extensions/link/helpers/autolink.ts b/app/utils/tiptap/extensions/link/helpers/autolink.ts
@@ -81,7 +81,11 @@ export function autolink(options: AutolinkOptions): Plugin {
           continue;
         }
 
-        const lastWordBeforeSpace = wordsBeforeWhitespace[wordsBeforeWhitespace.length - 1];
+        const lastWordBeforeSpace = wordsBeforeWhitespace.at(-1);
+        if (!lastWordBeforeSpace) {
+          continue;
+        }
+
         const lastWordAndBlockOffset = textBlock.pos + textBeforeWhitespace.lastIndexOf(lastWordBeforeSpace);
 
         if (!lastWordBeforeSpace) {
diff --git a/modules/purge-dev-only-strings.ts b/modules/purge-dev-only-strings.ts
@@ -3,6 +3,8 @@ import decomment from 'decomment';
 import MagicString from 'magic-string';
 import { isDevelopment } from 'std-env';
 
+const DATA_TEST_REGEXP = /data-testId=".*?"/g;
+
 // NOTE: taken from - https://github.com/elk-zone/elk/blob/main/modules/purge-comments.ts
 export default defineNuxtModule({
   meta: {
@@ -23,7 +25,7 @@ export default defineNuxtModule({
 
         const s = new MagicString(code);
 
-        s.replaceAll(/data-testId=".*?"/g, '');
+        s.replaceAll(DATA_TEST_REGEXP, '');
 
         return {
           code: s.toString(),
diff --git a/nuxt.config.ts b/nuxt.config.ts
@@ -15,6 +15,9 @@ import { InvariantOptimization } from './unplugin/invariant-optimization';
 import { parseDurationFunctionName, ParseDurationTransformPlugin } from './unplugin/parse-duration';
 import { SmallerEmojiMart } from './unplugin/smaller-emoji-mart';
 
+const TIPTAP_REGEXP = /(?:^|\/)@?tiptap\//;
+const PROSEMIRROR_REGEXP = /(?:^|\/)prosemirror/;
+
 export default defineNuxtConfig({
   compatibilityDate: 'latest',
 
@@ -249,9 +252,9 @@ export default defineNuxtConfig({
     },
 
     plugins: [
-      ParseDurationTransformPlugin.rolldown(),
+      ParseDurationTransformPlugin.vite(),
       UnheadVite(),
-      SmallerEmojiMart.rolldown(),
+      SmallerEmojiMart.vite(),
     ],
 
     build: {
@@ -353,10 +356,10 @@ export default defineNuxtConfig({
         name: 'mock',
         enforce: 'pre',
         resolveId(id) {
-          if (/(?:^|\/)@?tiptap\//.test(id)) {
+          if (TIPTAP_REGEXP.test(id)) {
             return resolve('./app/mocks/tiptap.ts');
           }
-          if (/(?:^|\/)prosemirror/.test(id)) {
+          if (PROSEMIRROR_REGEXP.test(id)) {
             return resolve('./app/mocks/prosemirror.ts');
           }
         },
diff --git a/server/api/search/client.get.ts b/server/api/search/client.get.ts
@@ -40,5 +40,5 @@ export default defineEventHandler(async (event) => {
 
   timer.appendHeader(event);
 
-  return { data: notes.concat(folders) as Array<FuzzyItem> };
+  return { data: [...notes, ...folders] as Array<FuzzyItem> };
 });
diff --git a/server/utils/share.ts b/server/utils/share.ts
@@ -9,7 +9,7 @@ const DEFAULT_LINK_LENGTH = partsNumber * partLength;
 const nanoid = customAlphabet('0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ', DEFAULT_LINK_LENGTH);
 const splitLinkRE = new RegExp(`[A-Z\\d]{${partLength}}`, 'g');
 const linkRE = new RegExp(
-  Array.from({ length: partsNumber }, () => `[0-9A-Z]{${partLength}}`).join('-'),
+  Array.from({ length: partsNumber }).fill(`[0-9A-Z]{${partLength}}`).join('-'),
 );
 
 export function generateShareLink() {
diff --git a/server/utils/timers.ts b/server/utils/timers.ts
@@ -14,6 +14,7 @@ class Timer {
   start(name: string, desc?: string) {
     if (import.meta.dev && name.includes(' ')) {
       console.warn('timer name should not contain a whitespace');
+      // eslint-disable-next-line e18e/prefer-static-regex
       name = name.replace(/\s/g, '-');
     }
 
@@ -33,6 +34,7 @@ class Timer {
 
     if (name) {
       if (import.meta.dev) {
+        // eslint-disable-next-line e18e/prefer-static-regex
         name = name.replace(/\s/g, '-');
       }
 

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ function handleArrowsPress(event: KeyboardEvent) {`
`45`	`45`	`return;`
`46`	`46`	`}`
`47`	`47`
`48`		`- const currentIdx = Array.from(listElement.children)`
	`48`	`+ const currentIdx = [...listElement.children]`
`49`	`49`	`.findIndex((node) =>`
`50`	`50`	`// event.target will be anchor tag, but it is wrapped in li, which is list element child`
`51`	`51`	`node === (event.target as HTMLElement).parentElement,`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ function updateFocusableElements() {`
`20`	`20`	`return;`
`21`	`21`	`}`
`22`	`22`
`23`		`- const elements = Array.from(sidebar.value.querySelectorAll<FocusableElement>('a,button,select'));`
	`23`	`+ const elements = [...sidebar.value.querySelectorAll<FocusableElement>('a,button,select')];`
`24`	`24`
`25`	`25`	`focusableElements.value = elements;`
`26`	`26`	`}`