Skip to content

[HWORKS-555] Attach attribute error should be silent #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gibchikafa wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[HWORKS-555] Attach attribute error should be silent #21

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9daf062
Attach attribute error should be silent
gibchikafa Apr 21, 2023
df15f87
Display error if we fail to attach the xattribute
gibchikafa May 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion sparkmagic/sparkmagic/livyclientlib/livysession.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,14 @@ def start(self):
self.properties['conf']['spark.yarn.appMasterEnv.HOPSWORKS_KERNEL_ID'] = kernel_id
self.properties['conf']['spark.executorEnv.HOPSWORKS_KERNEL_ID'] = kernel_id
if 'hops.util' in sys.modules:
util.attach_jupyter_configuration_to_notebook(kernel_id)
try:
util.attach_jupyter_configuration_to_notebook(kernel_id)
except Exception as e:
self.logger.error(e)
self.ipython_display.send_error(u"Warning: Failed to attach jupyter configuration to notebook. {}".format(str(e)))
pass



self.properties['cert'] = {}
material_directory = os.environ.get(constants.MATERIAL_DIRECTORY)
Expand Down