From 9daf062471002a980fd336523a3feb52314ebe8a Mon Sep 17 00:00:00 2001 From: Gibson Chikafa Date: Fri, 21 Apr 2023 15:30:06 +0200 Subject: [PATCH 1/2] Attach attribute error should be silent --- sparkmagic/sparkmagic/livyclientlib/livysession.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/sparkmagic/sparkmagic/livyclientlib/livysession.py b/sparkmagic/sparkmagic/livyclientlib/livysession.py index 9b192d3e..3394f5b6 100644 --- a/sparkmagic/sparkmagic/livyclientlib/livysession.py +++ b/sparkmagic/sparkmagic/livyclientlib/livysession.py @@ -147,7 +147,13 @@ def start(self): self.properties['conf']['spark.yarn.appMasterEnv.HOPSWORKS_KERNEL_ID'] = kernel_id self.properties['conf']['spark.executorEnv.HOPSWORKS_KERNEL_ID'] = kernel_id if 'hops.util' in sys.modules: - util.attach_jupyter_configuration_to_notebook(kernel_id) + try: + util.attach_jupyter_configuration_to_notebook(kernel_id) + except Exception as e: + self.logger.error(e) + pass + + self.properties['cert'] = {} material_directory = os.environ.get(constants.MATERIAL_DIRECTORY) From df15f874229926421a5a53744005e91b153ddeba Mon Sep 17 00:00:00 2001 From: Gibson Chikafa Date: Wed, 17 May 2023 11:09:35 +0200 Subject: [PATCH 2/2] Display error if we fail to attach the xattribute --- sparkmagic/sparkmagic/livyclientlib/livysession.py | 1 + 1 file changed, 1 insertion(+) diff --git a/sparkmagic/sparkmagic/livyclientlib/livysession.py b/sparkmagic/sparkmagic/livyclientlib/livysession.py index 3394f5b6..ba9ae8bc 100644 --- a/sparkmagic/sparkmagic/livyclientlib/livysession.py +++ b/sparkmagic/sparkmagic/livyclientlib/livysession.py @@ -151,6 +151,7 @@ def start(self): util.attach_jupyter_configuration_to_notebook(kernel_id) except Exception as e: self.logger.error(e) + self.ipython_display.send_error(u"Warning: Failed to attach jupyter configuration to notebook. {}".format(str(e))) pass