Remove set_text forced flag

Author: loftafi

build.zig.zon

@@ -1,6 +1,6 @@
 .{
     .name = .engine,
-    .version = "0.9.12",
+    .version = "0.9.13",
     .fingerprint = 0xe8a81a8d0aa558d5,
     .minimum_zig_version = "0.15.2",
     .dependencies = .{

src/element.zig

@@ -626,14 +626,15 @@ pub const Element = struct {
 
     /// set_text updates the `text` and `translation` fields of labels,
     /// checkboxes and buttons, and regenerates the grahpics/image
-    /// textures for each word if the text was changed or `forced`
-    /// is requested.
+    /// textures for each word if the text was changed.
+    ///
+    /// The memory behind the `new_text` must remain valid while the element
+    /// exists and is displaying this string.
     pub inline fn set_text(
         self: *Element,
         allocator: Allocator,
         display: *Display,
         new_text: []const u8,
-        forced: bool,
     ) error{OutOfMemory}!void {
         const old_translated = switch (self.type) {
             .text_input => self.type.text_input.text.items,
@@ -664,9 +665,9 @@ pub const Element = struct {
             old_translated,
             new_translated,
         });
-        if (std.mem.eql(u8, new_translated, old_translated) and !forced) {
-            // Don't update if nothing changed
-            // TODO: This should not be needed
+        if (std.mem.eql(u8, new_translated, old_translated)) {
+            // Do nothing if the text has not changed. This assumes that
+            // the original text buffer was not modified.
             return;
         }
 
@@ -1026,9 +1027,9 @@ pub const Element = struct {
     /// a chance to regenerate its translation and text texture.
     pub fn language_changed(self: *Element, allocator: Allocator, display: *Display, lang: Lang) !void {
         switch (self.type) {
-            .label => try self.set_text(allocator, display, self.type.label.text, false),
-            .checkbox => try self.set_text(allocator, display, self.type.checkbox.text, false),
-            .button => try self.set_text(allocator, display, self.type.button.text, false),
+            .label => try self.set_text(allocator, display, self.type.label.text),
+            .checkbox => try self.set_text(allocator, display, self.type.checkbox.text),
+            .button => try self.set_text(allocator, display, self.type.button.text),
             .panel => for (self.type.panel.children.items) |child| {
                 try child.language_changed(allocator, display, lang);
             },

src/engine.zig

@@ -2822,7 +2822,7 @@ pub fn setup_checkbox(
     if (element.focus == .unspecified)
         element.focus = .can_focus;
 
-    try element.set_text(allocator, self, element.type.checkbox.text, true);
+    try element.set_text(allocator, self, element.type.checkbox.text);
 
     if (try self.load_texture(allocator, "ios-checkbox-on")) |texture| {
         element.type.checkbox.on_texture = texture;
@@ -2879,7 +2879,7 @@ pub fn setup_label(
         else
             element.focus = .accessibility_focus;
     }
-    try element.set_text(allocator, self, element.type.label.text, true);
+    try element.set_text(allocator, self, element.type.label.text);
 
     // Is there a background for this label?
     if (element.background.image_name) |name| {
@@ -2934,9 +2934,9 @@ pub fn setup_text_input(
     element.type.text_input.text = .empty;
     element.type.text_input.runes = .empty;
     if (element.type.text_input.initial_text) |text| {
-        try element.set_text(allocator, self, text, true);
+        try element.set_text(allocator, self, text);
     } else {
-        try element.set_text(allocator, self, "", true);
+        try element.set_text(allocator, self, "");
     }
     if (element.type.text_input.placeholder_text) |text| {
         try element.set_placeholder_text(allocator, self, text);
@@ -3031,7 +3031,7 @@ pub fn setup_button(
             element.background.image_name.?,
         });
 
-    try element.set_text(allocator, display, element.type.button.text, true);
+    try element.set_text(allocator, display, element.type.button.text);
 
     if (element.type.button.icon_default_name) |icon_default| {
         if (try display.load_texture(allocator, icon_default)) |texture| {
@@ -3535,7 +3535,7 @@ test "button sizing" {
     try std.testing.expect(display.resources.by_uid.count() > 0);
     _ = try display.load_font(allocator, "Roboto-Light");
 
-    try button.set_text(allocator, display, "Hello", true);
+    try button.set_text(allocator, display, "Hello");
     display.relayout();
     try eq(83, @trunc(button.rect.width));
     try eq(100, @trunc(panel.rect.width));