Skip to content

Bug in llama-stack-client CLI #211

@JoshSalomon

Description

@JoshSalomon

System Info

llama-stack-client --version
llama-stack-client, version 0.1.8

Information

  • The official example scripts
  • My own modified scripts

🐛 Describe the bug

The command llama-stack-client datasets register has a mandatory parameter --schema. Without this parameter you get the error

Usage: llama-stack-client datasets register [OPTIONS]

Error: Missing option '--schema'.

When adding the --schema argument you get the following error:

╭──────────────────────────────────────────────────────────────────────────────────╮
│ Failed to register dataset                                                       │
│                                                                                  │
│ Error Type: TypeError                                                            │
│ Details: DatasetsResource.register() got an unexpected keyword argument          │
│ 'dataset_schema'                                                                 │
╰──────────────────────────────────────────────────────────────────────────────────╯

The command I used is:

llama-stack-client datasets register   --dataset-id "josh2"   --provider-id "localfs"   --url "file://home/jsalomon/src/llama-stack/data.txt"   --metadata '{"path": "llamastack/evals", "name": "evals__mmlu__details", "split": "train"}'   --schema '{"input_query": {"type": "string"}, "expected_answer": {"type": "string"}, "chat_completion_input": {"type": "string"}}'

This is the result of the dataset API refactoring which is not reflected to the CLI

Error logs

NA

Expected behavior

As of the last refactoring of the dataset API the schema parameter should be removed from the CLI.
Accordingly, a new mandatory parameter was added to the registration (purpose) and it should be added to the CLI as a mandatory parameter.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions