-
Notifications
You must be signed in to change notification settings - Fork 87
Description
Hi, thanks for your great work.
I am reading your codes and one thing confuses me.
For the spherical tracing part, accoring to the paper, it should find the first intersection point (which is also nearer) first and if it is not convergent, the algorithm will begin at the another intersection point, which is the farthest point.
However, when I read the codes, the start_point seems to be farther from the camera center than the end_points because the start_points choose the index 0 of "sphere_intersections_points" and the end_points choose index 1.

Because according to "get_sphere_intersection" function,
the index 0 stores (-under_sqrt - ray_cam_dot) and index 1 stores (under_sqrt - ray_cam_dot), which means the tensors on index 0 have larger absolute value.
So it seems that start_points will be farther than the end_points, which is comfusing.
Did I get anything wrong?